Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5830 Move deleteExpired logic to messageRenderer and perform once per minute instead of every seconds #5840

Merged
merged 2 commits into from
Sep 20, 2024
Merged

#5830 Move deleteExpired logic to messageRenderer and perform once per minute instead of every seconds #5840

merged 2 commits into from
Sep 20, 2024

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Sep 20, 2024 •
edited by sosnovsky
Loading

This PR moved deleteExpired logic to messageRenderer and perform once per minute instead of every seconds

close #5830// if this PR closes an issue

Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226 ioanmo226 marked this pull request as ready for review September 20, 2024 04:31
sosnovsky
sosnovsky approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sosnovsky sosnovsky merged commit 6cb74ee into master Sep 20, 2024
13 checks passed
@sosnovsky sosnovsky deleted the 5830-expirationcachedeleteexpired-should-be-performed-only-1-time-per-minute branch September 20, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expirationCacheDeleteExpired should be performed only 1 time per minute
2 participants
@ioanmo226 @sosnovsky