Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5831 Remove chrome.tabs.onUpdated listener in firefox #5837

Merged
merged 1 commit into from
Sep 18, 2024
Merged

#5831 Remove chrome.tabs.onUpdated listener in firefox #5837

merged 1 commit into from
Sep 18, 2024

Conversation

ioanmo226
Copy link
Collaborator

@ioanmo226 ioanmo226 commented Sep 18, 2024 •
edited by sosnovsky
Loading

This PR removed chrome.tabs.onUpdated listener in firefox

close #5831 // if this PR closes an issue

Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanmo226
Copy link
Collaborator Author

Seems to work well in firefox even after removing chrome.tabs.onUpdated listener

@ioanmo226 ioanmo226 marked this pull request as ready for review September 18, 2024 10:46
sosnovsky
sosnovsky approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well in firefox even after removing chrome.tabs.onUpdated listener

Yeah, and stuck loading... issue seems to be fixed for me 👍

@sosnovsky sosnovsky merged commit f20e37d into master Sep 18, 2024
12 checks passed
@sosnovsky sosnovsky deleted the 5831-check-if-chrometabsonupdated-still-needed-for-firefox-scripts-injection branch September 18, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check if chrome.tabs.onUpdated still needed for Firefox scripts injection
2 participants
@ioanmo226 @sosnovsky