-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5667 Decrypt messages in Thunderbird #5824
Conversation
…ion to an appropriate Class
…ssage-decryption-on-thunderbird
…ssage-decryption-on-thunderbird
…ssage-decryption-on-thunderbird
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
2422507 | Triggered | Generic Password | f901bc5 | extension/chrome/elements/compose.ts | View secret |
2422507 | Triggered | Generic Password | 1f56012 | extension/chrome/elements/compose.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well. Thanks for your help @sosnovsky for finalizing this PR reaching its completion.
@@ -149,8 +149,10 @@ export class BgHandlers { | |||
}; | |||
|
|||
public static thunderbirdContentScriptRegistration = async () => { | |||
const contentScriptGroups = chrome.runtime.getManifest().content_scripts ?? []; // we know it's in the manifest | |||
const files = contentScriptGroups[0].js?.map(url => url.replace(/moz-extension:\/\/[^/]+\//, './')) ?? []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This where dynamic content script injection comes in place. It's actually the best solution that I can't implement - its a great inclusion where we don't actually need to bundle the entire js libs and dependencies.
Hi @sosnovsky - I think we can merge this one now. thank you! |
Hello @martgil, I've added some code simplifications, can you please re-check, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still works well after the code refactor. Thank you!
This PR added message decryption and its necessary UI improvements on Thunderbird email client.
close #5667
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):