#5811 Added ability to generate keys in the extension

[ioanmo226]

This PR added ability to generate keys in the extension

close #5811 // if this PR closes an issue

---

Tests (delete all except exactly one):

• Tests added or updated

---

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

• addresses the issue it closes (if any)
• code is readable and understandable
• is accompanied with tests, or tests are not needed
• is free of vulnerabilities
• is documented clearly and usefully, or doesn't need documentation

[ioanmo226]

@sosnovsky Implementation is now finished. Will be adding UI test now.
In the meantime,could you test functionality and let me know if you want some changes?

[sosnovsky]

@ioanmo226 I expected this functionality to be added to the existing Add key modal, like described in #5811 (comment). Will it be too complicated to move it there?

[ioanmo226]

I saw that comment.
But there are only radio boxes in Add key modal. Thought not good UI/UX to add Generate key button in there.

[ioanmo226]

Let me know if you want to place Generate Key button in modal.
If so, do I have to place at the top of radio checkboxes? Should it be button or radio type?

[sosnovsky]

Yes, let's place it in the modal as radio button, like other options:

[ioanmo226]

If user clicks Generate new key button it should replace modal with generate key view?

[ioanmo226]

Or display generate key view under the radio buttons?

[sosnovsky]

Or display generate key view under the radio buttons?

It should appear below radio buttons, so users will be able to switch between different options:

[ioanmo226]

I see. Let me implement that way

[ioanmo226]

Hmm... strange..
Tests pass locally without any problem but in semaphoreci, several tests fail.
Maybe because of concurrent test runs?
Checking deeply now

[sosnovsky]

Semaphore tests stuck on this screen:

As I remember, we had 2 keys for flowcrypt.compatibility, maybe third key is added in some test and it affects all tests running after it?

[ioanmo226]

Ohhh. Yep
That's it.
It would be because I added new test settings - my key page - generate key which generated new key.

[ioanmo226]

Thank you for your hint. I thought tests were isolated and tests each other don't affect others. But seems like add/generate key affects other tests

[sosnovsky]

Well done, works great 👍