Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5740 Re-arrange processing of newlines in quoted email #5743

Merged
merged 7 commits into from
Jun 5, 2024

Conversation

martgil
Copy link
Collaborator

@martgil martgil commented May 27, 2024

This PR re-arrange the processing of newlines in quoted email + remove style which results to "inline divs" that causes issue described in #5740.

close #5740


Tests (delete all except exactly one):

  • Test added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

- Remove styling that causes inline-block div that produces problem
@martgil
Copy link
Collaborator Author

martgil commented May 27, 2024

Hi @sosnovsky - I will also share another custom build with the reporting user to confirm the fix, in addition to my personal verification.

@martgil
Copy link
Collaborator Author

martgil commented Jun 5, 2024

To test this one manually, in addition to the updated test:

  1. ) Open any secure email on Gmail that the FlowCrypt extension can render.
  2. ) Once a secure email from your inbox, click the "..." icon to see the quoted text part.
  3. ) On the section where the line "On 202x-01-01 at 12:00, [email protected] wrote:" try to press enter and you'll get the desired newline compare with bugged version where div's after div's is injected due to the "inline-block" css property from the consumer build. The issue that happens when interacting onto the last instance of ">" in the quoted text part is also fixed.

@martgil martgil marked this pull request as ready for review June 5, 2024 12:03
@martgil martgil requested a review from sosnovsky as a code owner June 5, 2024 12:03
@martgil
Copy link
Collaborator Author

martgil commented Jun 5, 2024

Hi @sosnovsky - this one is ready for review. thank you!

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

@sosnovsky sosnovsky merged commit 2e14422 into master Jun 5, 2024
13 checks passed
@sosnovsky sosnovsky deleted the issue-5740-re-arrange-processing-of-newlines branch June 5, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing "Enter" twice in beginning/endings of quoted text required before a newline actually rendered
2 participants