Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5715 Fix id token fetch for exception reports #5717

Merged
merged 2 commits into from
May 19, 2024

Conversation

sosnovsky
Copy link
Collaborator

@sosnovsky sosnovsky commented May 17, 2024

This PR fixes id token fetch for sending error reports from content script.

+ replaces { line: 0, col: 0 } with { line: 1, col: 1} for reports with unknown error location (as backend expects positive number, and throws error when line or col is 0)

close #5715


Tests (delete all except exactly one):


To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@sosnovsky sosnovsky requested a review from ioanmo226 May 18, 2024 18:16
@ioanmo226 ioanmo226 enabled auto-merge (squash) May 19, 2024 01:27
Copy link
Collaborator

@ioanmo226 ioanmo226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ioanmo226 ioanmo226 merged commit fd04af8 into master May 19, 2024
14 checks passed
@ioanmo226 ioanmo226 deleted the 5715-fix-error-reports-auth branch May 19, 2024 01:27
ioanmo226 pushed a commit that referenced this pull request May 27, 2024
* #5715 Fix id token fetch for exception reports

* pr review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error reports send unauthorized requests from content script
2 participants