#5610 fix: windows build issue

[ioanmo226]

This PR fixed build issue in windows system.

close #5610 // if this PR closes an issue

---

Tests (delete all except exactly one):

• Does not need tests (refactor only, docs or internal changes)

---

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

• addresses the issue it closes (if any)
• code is readable and understandable
• is accompanied with tests, or tests are not needed
• is free of vulnerabilities
• is documented clearly and usefully, or doesn't need documentation

[ioanmo226]

Hmm... This one seems complex than I've imagined.
when we use sh in linux, it doesn't recognize set -euxo pipefail
when we use bash in windows, it throws below error in cygwin

scripts/build.sh: line 2: $'\r': command not found
scripts/build.sh: line 7: $'\r': command not found
: invalid option namee 8: set: pipefail

[ioanmo226]

Also in git bash sh build.sh works but in cygwin sh build.sh throws error.
Maybe shell version is different?

[ioanmo226]

This cross-platform build cannot be easily developed or maintained with a bash script.
Therefore, my suggestion is to rewrite the script using Node.js. By doing so, the script will function properly across all platforms, independent of bash versions and platform differences.

@sosnovsky What do you think?
Do you think this one is worth doing it? If so when? right now or low priority?

[sosnovsky]

This cross-platform build cannot be easily developed or maintained with a bash script. Therefore, my suggestion is to rewrite the script using Node.js. By doing so, the script will function properly across all platforms, independent of bash versions and platform differences.

@sosnovsky What do you think? Do you think this one is worth doing it? If so when? right now or low priority?

I think it'll require too much time as our build script is quite complicated and it won't be easy to rewrite it using node.js.
Our main dev environments are macOS and linux, so it'll be ok to support only them for now.

Also in git bash sh build.sh works but in cygwin sh build.sh throws error.

Maybe it fails because of the first line in build.sh - #!/usr/bin/env bash, as it's specific for *nix systems.

If you need to build extension on Windows, it'll probably be better to create copy of build.sh and name it build-windows.sh, then update it's code to work in cygwin, and add new script to package.json - "build-windows": "sh ./scripts/build-windows.sh"

[ioanmo226]

I'm also using Mac and Linux so it's not a problem.
Do you wanna me to take a look at this one first or manifest v3 update?

[sosnovsky]

let's work on manifest v3 update, as currently there is no need to fix build on windows