Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved FileProvider usage #2932

Merged
merged 12 commits into from
Feb 3, 2025
Merged

Conversation

DenBond7
Copy link
Collaborator

@DenBond7 DenBond7 commented Jan 29, 2025

This PR improved FileProvider usage

close #2930


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7 DenBond7 marked this pull request as ready for review January 29, 2025 17:50
@DenBond7 DenBond7 requested a review from sosnovsky as a code owner January 29, 2025 17:50
@DenBond7
Copy link
Collaborator Author

DenBond7 commented Feb 3, 2025

@sosnovsky ping

@sosnovsky
Copy link
Collaborator

Hi @DenBond7, will check it today!

@sosnovsky
Copy link
Collaborator

I tried to open attachment by clicking preview button:

Screenshot 2025-02-03 at 10 22 14

And then choosing open in chrome, but chrome failed to access attachment with such error:
Screenshot 2025-02-03 at 10 21 15

Can it be caused by stricter file permissions in current PR?

@DenBond7
Copy link
Collaborator Author

DenBond7 commented Feb 3, 2025

Can it be caused by stricter file permissions in current PR?

Nope. I have the same behavior on the active production build(Google Play). It looks like Chrome can't handle such a Uri. I can open an attachment like yours via Gmail.

@DenBond7
Copy link
Collaborator Author

DenBond7 commented Feb 3, 2025

This PR includes internal changes. It can affect Android 9 or less. Android 10 and higher should not be affected by these changes.

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, otherwise looks good 👍

@sosnovsky sosnovsky merged commit 7a5b997 into master Feb 3, 2025
7 checks passed
@sosnovsky sosnovsky deleted the issue_2930_improve_FileProvider_usage branch February 3, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve FileProvider usage
2 participants