-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated to use 'shared-tenant-fes/api/v1/account/feedback' #2920
Conversation
Moved back to draft. Need to remove some unused code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed a small issue when testing on Android emulator - after sending feedback message, app stays on feedback screen, and it looks like message wasn't send.
But I checked our feedback account and message was successfully received.
Does it happen only in emulator or it's expected behavior?
steps to reproduce:
- launch app
- open side menu
- tap
Report problem
- send feedback message
- app stays on feedback screen
Sorry, I've missed that. I've compared it with the old code and found the app should navigate up with the following toast I've found the reason. I will fix it shorlty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well now 👍
This PR Migrated to use 'shared-tenant-fes/api/v1/account/feedback' + fixed one small UI bug
close #2827
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):