Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated to use 'shared-tenant-fes/api/v1/account/feedback' #2920

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

DenBond7
Copy link
Collaborator

@DenBond7 DenBond7 commented Dec 30, 2024

This PR Migrated to use 'shared-tenant-fes/api/v1/account/feedback' + fixed one small UI bug

close #2827


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7 DenBond7 marked this pull request as ready for review January 6, 2025 10:31
@DenBond7 DenBond7 requested a review from sosnovsky as a code owner January 6, 2025 10:31
@DenBond7 DenBond7 marked this pull request as draft January 6, 2025 10:34
@DenBond7
Copy link
Collaborator Author

DenBond7 commented Jan 6, 2025

Moved back to draft. Need to remove some unused code.

@DenBond7 DenBond7 marked this pull request as ready for review January 6, 2025 12:50
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a small issue when testing on Android emulator - after sending feedback message, app stays on feedback screen, and it looks like message wasn't send.
But I checked our feedback account and message was successfully received.
Does it happen only in emulator or it's expected behavior?

steps to reproduce:

  • launch app
  • open side menu
  • tap Report problem
  • send feedback message
  • app stays on feedback screen

@DenBond7
Copy link
Collaborator Author

DenBond7 commented Jan 8, 2025

I noticed a small issue when testing on Android emulator - after sending feedback message, app stays on feedback screen, and it looks like message wasn't send. But I checked our feedback account and message was successfully received. Does it happen only in emulator or it's expected behavior?

Sorry, I've missed that. I've compared it with the old code and found the app should navigate up with the following toast <string name="thank_you_for_feedback">Thank you for the feedback</string>, but it doesn't do that.

I've found the reason. shared-tenant-fes/api/v1/account/feedback uses a different response format. It sends an empty reply for the success. But /api/help/feedback sends isSent: true(I check that parameter).

I will fix it shorlty

@DenBond7 DenBond7 requested a review from sosnovsky January 8, 2025 10:35
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well now 👍

@sosnovsky sosnovsky merged commit 1483fde into master Jan 8, 2025
8 checks passed
@sosnovsky sosnovsky deleted the issue_2827_migrate_feedback_api branch January 8, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use FES /account/feedback endpoint
2 participants