Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added '--info' when run instrumentation tests.| #2649 #2655

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Added '--info' when run instrumentation tests.| #2649 #2655

merged 2 commits into from
Mar 25, 2024

Conversation

DenBond7
Copy link
Collaborator

@DenBond7 DenBond7 commented Mar 25, 2024 •
edited by sosnovsky
Loading

This PR Added '--info' when run instrumentation tests for better debugging

issue #2649

Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7 DenBond7 marked this pull request as ready for review March 25, 2024 13:03
@DenBond7 DenBond7 requested a review from sosnovsky as a code owner March 25, 2024 13:03
sosnovsky
sosnovsky approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sosnovsky sosnovsky merged commit ac35040 into master Mar 25, 2024
8 checks passed
@sosnovsky sosnovsky deleted the issue_2649_device_offline branch March 25, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DenBond7 @sosnovsky