Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKM keys refresh: allow removing keys + improve revoked handing #1863

Merged

Conversation

DenBond7
Copy link
Collaborator

This PR improved revoked handing

close #1768


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities

@DenBond7 DenBond7 added this to the 1.3.5: Revoked keys milestone Jun 22, 2022
import org.junit.Test
import org.junit.runner.RunWith
import org.robolectric.RobolectricTestRunner
import org.robolectric.RuntimeEnvironment

@RunWith(RobolectricTestRunner::class)
@Ignore(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled due to #1865

@DenBond7 DenBond7 marked this pull request as ready for review June 23, 2022 11:04
@DenBond7 DenBond7 requested a review from IvanPizhenko as a code owner June 23, 2022 11:04
@DenBond7 DenBond7 merged commit fec17a3 into master Jun 23, 2022
@DenBond7 DenBond7 deleted the issue_1768_ekm_disallow_updating_removing_revoked_keys branch June 23, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EKM keys refresh: allow removing keys, except when revoked + improve revoked handing
2 participants