Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(testing): update instructions for testing #57

Merged
merged 3 commits into from
Nov 4, 2022
Merged

feat(testing): update instructions for testing #57

merged 3 commits into from
Nov 4, 2022

Conversation

0xCCY
Copy link
Contributor

@0xCCY 0xCCY commented Nov 3, 2022

  • added testing.md which includes detailed steps to test plugin locally
  • added plugin-dev.md which explain the various implementation
  • added new child for "Porting Plugin" in sidebar for consistency
  • added link to Python and JS plugin docs in json-rpc.md

jjw24
jjw24 reviewed Nov 3, 2022
View reviewed changes
jjw24
jjw24 reviewed Nov 3, 2022
View reviewed changes
jjw24
jjw24 reviewed Nov 3, 2022
View reviewed changes
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added two tips, please commit if you think it's ok.

0xCCY and others added 2 commits November 3, 2022 20:19
@0xCCY @jjw24
Update testing.md
0748093 
Co-authored-by: Jeremy Wu <[email protected]>
@0xCCY @jjw24
Update testing.md
bd2d2ac 
Co-authored-by: Jeremy Wu <[email protected]>
jjw24
jjw24 approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@jjw24 jjw24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend, thank you 👍

@jjw24 jjw24 merged commit 8e4c02c into Flow-Launcher:main Nov 4, 2022
@jjw24 jjw24 added the documentation Improvements or additions to documentation label Nov 4, 2022
@jjw24 jjw24 mentioned this pull request Nov 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjw24 jjw24 jjw24 approved these changes

Assignees

@0xCCY 0xCCY

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xCCY @jjw24