update to .net 9 #3286
update to .net 9 #3286
Conversation
This comment has been minimized.
This comment has been minimized.
|
🥷 Code experts: jjw24 jjw24 has most 🧠 knowledge in the files. See details
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame:
Knowledge based on git-blame: To learn more about /:\ gitStream - Visit our Docs |
|
Be a legend 🏆 by adding a before and after screenshot of the changes you made, especially if they are around UI/UX. |
📝 WalkthroughWalkthroughThis pull request updates multiple project files and scripts to use .NET 9 instead of .NET 7. The changes include modifying the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (21)
Flow.Launcher.Core/Flow.Launcher.Core.csproj(1 hunks)Flow.Launcher.Infrastructure/Flow.Launcher.Infrastructure.csproj(1 hunks)Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj(1 hunks)Flow.Launcher.Test/Flow.Launcher.Test.csproj(1 hunks)Flow.Launcher/Flow.Launcher.csproj(1 hunks)Flow.Launcher/Properties/PublishProfiles/Net7.0-SelfContained.pubxml(0 hunks)Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj(1 hunks)Plugins/Flow.Launcher.Plugin.Calculator/Flow.Launcher.Plugin.Calculator.csproj(1 hunks)Plugins/Flow.Launcher.Plugin.Explorer/Flow.Launcher.Plugin.Explorer.csproj(1 hunks)Plugins/Flow.Launcher.Plugin.PluginIndicator/Flow.Launcher.Plugin.PluginIndicator.csproj(1 hunks)Plugins/Flow.Launcher.Plugin.PluginsManager/Flow.Launcher.Plugin.PluginsManager.csproj(1 hunks)Plugins/Flow.Launcher.Plugin.ProcessKiller/Flow.Launcher.Plugin.ProcessKiller.csproj(1 hunks)Plugins/Flow.Launcher.Plugin.Program/Flow.Launcher.Plugin.Program.csproj(1 hunks)Plugins/Flow.Launcher.Plugin.Shell/Flow.Launcher.Plugin.Shell.csproj(1 hunks)Plugins/Flow.Launcher.Plugin.Sys/Flow.Launcher.Plugin.Sys.csproj(1 hunks)Plugins/Flow.Launcher.Plugin.Url/Flow.Launcher.Plugin.Url.csproj(1 hunks)Plugins/Flow.Launcher.Plugin.WebSearch/Flow.Launcher.Plugin.WebSearch.csproj(1 hunks)Plugins/Flow.Launcher.Plugin.WindowsSettings/Flow.Launcher.Plugin.WindowsSettings.csproj(1 hunks)README.md(1 hunks)Scripts/flowlauncher.nuspec(1 hunks)Scripts/post_build.ps1(1 hunks)
💤 Files with no reviewable changes (1)
- Flow.Launcher/Properties/PublishProfiles/Net7.0-SelfContained.pubxml
🧰 Additional context used
🧠 Learnings (4)
Flow.Launcher.Infrastructure/Flow.Launcher.Infrastructure.csproj (1)
Learnt from: taooceros
PR: Flow-Launcher/Flow.Launcher#2616
File: Flow.Launcher/Flow.Launcher.csproj:7-7
Timestamp: 2024-11-12T03:58:56.325Z
Learning: In the Flow Launcher project, the version number in the `Flow.Launcher.csproj` file is dynamically updated during the CI/CD process.
Flow.Launcher/Flow.Launcher.csproj (1)
Learnt from: taooceros
PR: Flow-Launcher/Flow.Launcher#2616
File: Flow.Launcher/Flow.Launcher.csproj:7-7
Timestamp: 2024-11-12T03:58:56.325Z
Learning: In the Flow Launcher project, the version number in the `Flow.Launcher.csproj` file is dynamically updated during the CI/CD process.
Flow.Launcher.Core/Flow.Launcher.Core.csproj (1)
Learnt from: taooceros
PR: Flow-Launcher/Flow.Launcher#2616
File: Flow.Launcher/Flow.Launcher.csproj:7-7
Timestamp: 2024-11-12T03:58:56.325Z
Learning: In the Flow Launcher project, the version number in the `Flow.Launcher.csproj` file is dynamically updated during the CI/CD process.
Flow.Launcher.Test/Flow.Launcher.Test.csproj (1)
Learnt from: taooceros
PR: Flow-Launcher/Flow.Launcher#2616
File: Flow.Launcher/Flow.Launcher.csproj:7-7
Timestamp: 2024-11-12T03:58:56.325Z
Learning: In the Flow Launcher project, the version number in the `Flow.Launcher.csproj` file is dynamically updated during the CI/CD process.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: gitStream.cm
🔇 Additional comments (19)
Scripts/flowlauncher.nuspec (1)
14-14: Target framework correctly updated to .NET 9The target path has been properly updated from
net7.0tonet9.0, which aligns with the overall objective of updating the project to .NET 9.Plugins/Flow.Launcher.Plugin.Url/Flow.Launcher.Plugin.Url.csproj (1)
5-5: Target framework correctly updated to .NET 9The TargetFramework has been properly updated from
net7.0-windowstonet9.0-windows, which aligns with the PR's objective of upgrading to .NET 9.Plugins/Flow.Launcher.Plugin.WindowsSettings/Flow.Launcher.Plugin.WindowsSettings.csproj (1)
4-4: Target framework correctly updated to .NET 9The TargetFramework has been properly updated from
net7.0-windowstonet9.0-windows, which aligns with the PR's objective of upgrading to .NET 9.Plugins/Flow.Launcher.Plugin.Shell/Flow.Launcher.Plugin.Shell.csproj (1)
5-5: Target framework correctly updated to .NET 9The TargetFramework has been properly updated from
net7.0-windowstonet9.0-windows, which aligns with the PR's objective of upgrading to .NET 9.Plugins/Flow.Launcher.Plugin.WebSearch/Flow.Launcher.Plugin.WebSearch.csproj (1)
5-5: Target Framework Update VerificationThe
<TargetFramework>element has been successfully updated tonet9.0-windows. This change is fully aligned with the project's upgrade objective to .NET 9.Plugins/Flow.Launcher.Plugin.Calculator/Flow.Launcher.Plugin.Calculator.csproj (1)
5-5: Target Framework Update VerificationThe
<TargetFramework>element now specifiesnet9.0-windows, which is consistent with the overall upgrade to .NET 9. Please ensure that all referenced dependencies and project integrations remain compatible with the new framework version.Plugins/Flow.Launcher.Plugin.Explorer/Flow.Launcher.Plugin.Explorer.csproj (1)
5-5: Framework Upgrade ConfirmationThe project file now targets
net9.0-windows, confirming the migration from .NET 7. This update is consistent with the other projects in the solution, ensuring uniformity across the ecosystem.Plugins/Flow.Launcher.Plugin.ProcessKiller/Flow.Launcher.Plugin.ProcessKiller.csproj (1)
5-5: Target Framework Update ConfirmationThe
<TargetFramework>is updated tonet9.0-windows, which aligns with the broader project upgrade to .NET 9. Verify that all project references and any version-specific features in dependencies continue to function as expected with this change.Plugins/Flow.Launcher.Plugin.Program/Flow.Launcher.Plugin.Program.csproj (1)
5-5: Framework upgrade looks good.The upgrade from .NET 7 to .NET 9 is properly implemented. I notice that the package reference to Microsoft.Extensions.Caching.Memory (line 67) is already at version 9.0.0, which aligns correctly with the .NET 9 framework.
Scripts/post_build.ps1 (1)
102-102: Publish profile path correctly updated.The path has been appropriately updated to reference the .NET 9 publish profile instead of the .NET 7 one, which aligns with the framework upgrade.
Flow.Launcher.Plugin/Flow.Launcher.Plugin.csproj (1)
4-4: Framework upgrade looks good.The target framework has been properly updated from .NET 7 to .NET 9, maintaining consistency with the other project files in the solution.
Plugins/Flow.Launcher.Plugin.Sys/Flow.Launcher.Plugin.Sys.csproj (1)
5-5: Framework upgrade looks good.The target framework has been properly updated from .NET 7 to .NET 9, consistent with the other project files in the solution.
Flow.Launcher.Infrastructure/Flow.Launcher.Infrastructure.csproj (1)
4-4: Target Framework Update Verified in Infrastructure Project.
The update to<TargetFramework>net9.0-windows</TargetFramework>is in line with the overall migration to .NET 9. Please ensure that all WPF components and referenced packages are compatible with .NET 9.Flow.Launcher.Core/Flow.Launcher.Core.csproj (1)
4-4: Target Framework Updated in Core Project.
Changing the target framework to<TargetFramework>net9.0-windows</TargetFramework>correctly aligns with the broader upgrade. All related properties (such as enabling both WPF and Windows Forms) remain consistent.Plugins/Flow.Launcher.Plugin.PluginsManager/Flow.Launcher.Plugin.PluginsManager.csproj (1)
4-4: PluginsManager Target Framework Update.
The update to<TargetFramework>net9.0-windows</TargetFramework>ensures consistency with the overall .NET 9 migration. Please verify that all plugin-specific dependencies and settings continue to function as expected under the new framework.Plugins/Flow.Launcher.Plugin.BrowserBookmark/Flow.Launcher.Plugin.BrowserBookmark.csproj (1)
5-5: BrowserBookmark Plugin Framework Upgrade.
The updated<TargetFramework>net9.0-windows</TargetFramework>meets the new .NET 9 requirements. The project configuration, including output and copying settings, appears correct.Plugins/Flow.Launcher.Plugin.PluginIndicator/Flow.Launcher.Plugin.PluginIndicator.csproj (1)
5-5: PluginIndicator Target Framework Update.
The change to<TargetFramework>net9.0-windows</TargetFramework>is consistent with the migration objectives. Ensure that all package references and any inter-project dependencies have been validated for .NET 9 compatibility.Flow.Launcher.Test/Flow.Launcher.Test.csproj (1)
4-4: Target Framework Update in Test Project
The<TargetFramework>element is updated tonet9.0-windows10.0.19041.0, aligning the test project with the overall .NET 9 upgrade. Please verify that all tests run correctly under the new runtime.Flow.Launcher/Flow.Launcher.csproj (1)
5-5: Updated Target Framework for Main Launcher Project
The<TargetFramework>element has been updated tonet9.0-windows10.0.19041.0to reflect the migration to .NET 9. This change is crucial for leveraging the latest runtime features and performance improvements. Additionally, with the removal of the outdated comment regarding upgrading Microsoft.Extensions libraries, please ensure that the current package versions (e.g., for Microsoft.Extensions.DependencyInjection and Microsoft.Extensions.Hosting, both at version 7.0.0) are fully compatible with .NET 9.
| - Install .Net 9 SDK | ||
| - via Visual Studio installer | ||
| - via winget `winget install Microsoft.DotNet.SDK.7` | ||
| - Manually from [here](https://dotnet.microsoft.com/en-us/download/dotnet/7.0) | ||
| - Manually from [here](https://dotnet.microsoft.com/en-us/download/dotnet/9.0) |
There was a problem hiding this comment.
Inconsistency in SDK Installation Instructions
The README instructs to "Install .Net 9 SDK" and correctly updates the manual installation link to the .NET 9 download page. However, the winget command still references Microsoft.DotNet.SDK.7, which is inconsistent with the .NET 9 upgrade.
Please update the winget command to the correct package for .NET 9. For example:
- - via winget `winget install Microsoft.DotNet.SDK.7`
+ - via winget `winget install Microsoft.DotNet.SDK.9`This change will ensure developers install the intended SDK version.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - Install .Net 9 SDK | |
| - via Visual Studio installer | |
| - via winget `winget install Microsoft.DotNet.SDK.7` | |
| - Manually from [here](https://dotnet.microsoft.com/en-us/download/dotnet/7.0) | |
| - Manually from [here](https://dotnet.microsoft.com/en-us/download/dotnet/9.0) | |
| - Install .Net 9 SDK | |
| - via Visual Studio installer | |
| - via winget `winget install Microsoft.DotNet.SDK.9` | |
| - Manually from [here](https://dotnet.microsoft.com/en-us/download/dotnet/9.0) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Hello, do you think we need to fix this build issue - ambiguous reference between 'System.Windows.Controls.ContextMenu' and 'System.Windows.Forms.ContextMenu' from #3234? |
|
.net 10 seems to be pretty far away (at least another half year). I guess we can fix it in a separate pr. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. Pattern suggestions ✂️ (1)You could add these patterns to If the flagged items are 🤯 false positivesIf items relate to a ...
|
We have experienced various issue with outdated framework, and also .Net 9 provides an excited theme for WPF, which we could later use to improve our UI.
Additional Change:
Not working