Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Dev Experience w/ Docker Compose #1

Merged
merged 6 commits into from
Jun 4, 2024
Merged

Conversation

grippy
Copy link

@grippy grippy commented May 24, 2024

The existing docker stuff doesn't work locally for development.

The root docker-compose/Dockerfile assumes you want to run the most recent production container. The .devcontainer folder is mostly meant to be run from Github Codespaces (and it didn't work when I tried it).

  • This change copies the .devcontainer parts and modifies it to run the applications (see entrypoint.sh). The application should be reachable via http://mastodon.local.
  • This change doesn't do anything to enable configuring the :test environment. I suspect we'll do that once we start testing changes.

Copy link

@rockhunters08 rockhunters08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ... just make sure to merge to release-42 and not main

@grippy grippy changed the base branch from main to release-42 May 28, 2024 20:25
@grippy grippy changed the base branch from release-42 to main May 28, 2024 22:16
@grippy grippy merged commit b772a41 into main Jun 4, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants