Add skipped to failed() (#610)

* Add skipped to failed() * Update release_notes.md
Flank · Oct 11, 2019 · 4942e6f · 4942e6f
1 parent 8861f7b
commit 4942e6f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/release_notes.md b/release_notes.md
@@ -1,5 +1,9 @@
 ## next (unreleased)
 
+- 
+
+## v8.0.1
+
 - [#608](https://github.com/TestArmada/flank/pull/608) Use MatrixRollupOutcome to set exit code value. ([bootstraponline](https://github.com/bootstraponline))
 
 ## v8.0.0

diff --git a/test_runner/src/main/kotlin/ftl/json/SavedMatrix.kt b/test_runner/src/main/kotlin/ftl/json/SavedMatrix.kt
@@ -38,9 +38,13 @@ class SavedMatrix(matrix: TestMatrix) {
         if (this.state == FINISHED) finished(matrix)
     }
 
+    // ExitCodeFromRollupOutcome - https://github.com/bootstraponline/gcloud_cli/blob/137d864acd5928baf25434cf59b0225c4d1f9319/google-cloud-sdk/lib/googlecloudsdk/api_lib/firebase/test/exit_code.py#L46
     fun failed(): Boolean {
+        // outcome of the test execution.
+        // skipped means unsupported environment
         return when (outcome) {
             failure -> true
+            skipped -> true
             inconclusive -> true
             else -> false
         }