fix: Handle API URL with or without trailing slash #288
+22
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolodato
approved these changes
Jan 22, 2025
| @@ -0,0 +1,3 @@ | |||
| export function ensureTrailingSlash(str: string): string { | |||
| return str.replace(/\/+$/, '') + '/'; | |||
There was a problem hiding this comment.
Suggested change
| return str.replace(/\/+$/, '') + '/'; | |
| return str.endsWith('/') ? str : str + '/'; |
A URL such as https://flagsmith.example.com//// is technically distinct from https://flagsmith.example.com/, and this regex would remove all trailing slashes except one. I know this sounds like extreme bikeshedding but it's closer in line to what we do in other SDKs, e.g. Go, .NET, Node.js, Ruby
tiagoapolo
approved these changes
Jan 22, 2025
rolodato
changed the title
rolodato
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the flagsmith base url has a single trailing /. Whilst I considered using JavaScript's built in URL API, there's a chance that a polyfil would be needed to guarantee exact same behaviour so this seemed far less risky.