Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix release workflow #133

Merged
merged 5 commits into from
Jan 15, 2025
+2 −2
Merged

ci: fix release workflow #133

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a4d37b6
Bump DOTNET_VERSION in release.yml
matthewelwell Jan 15, 2025
ef85954
temp: add push to workflow trigger
matthewelwell Jan 15, 2025
5910b3f
Bump checkout version
matthewelwell Jan 15, 2025
024187b
Revert temp workflow trigger
matthewelwell Jan 15, 2025
116f1c8
uncomment publish step
matthewelwell Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ env:
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
DOTNET_NOLOGO: true
NuGetDirectory: ${{ github.workspace }}/nuget
DOTNET_VERSION: 7.0.x
DOTNET_VERSION: 8.0.x

defaults:
run:
@@ -19,7 +19,7 @@ jobs:
create_nuget:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 0

Unchanged files with check annotations Beta

View file
Flagsmith.Engine/Segment/Evaluator.cs
{
case Constants.Equal: return traitValueAsVersion == conditionValueAsVersion;
case Constants.NotEqual: return traitValueAsVersion != conditionValueAsVersion;
case Constants.GreaterThan: return traitValueAsVersion > conditionValueAsVersion;

Check warning on line 175 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.EngineTest, 8.0.x) 

'SemVersion.operator >(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 175 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.Engine) 

'SemVersion.operator >(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 175 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.Engine) 

'SemVersion.operator >(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 175 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.EngineTest, 6.0.x) 

'SemVersion.operator >(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 175 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.FlagsmithClient) 

'SemVersion.operator >(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 175 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.FlagsmithClient) 

'SemVersion.operator >(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 175 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.Client.Test) 

'SemVersion.operator >(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 175 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.Client.Test) 

'SemVersion.operator >(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 175 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.EngineTest) 

'SemVersion.operator >(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 175 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.EngineTest) 

'SemVersion.operator >(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 175 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.EngineTest, 7.0.x) 

'SemVersion.operator >(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 175 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.Client.Test, 6.0.x) 

'SemVersion.operator >(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 175 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.Client.Test, 7.0.x) 

'SemVersion.operator >(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 175 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.Client.Test, 8.0.x) 

'SemVersion.operator >(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'
case Constants.GreaterThanInclusive: return traitValueAsVersion >= conditionValueAsVersion;

Check warning on line 176 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.EngineTest, 8.0.x) 

'SemVersion.operator >=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 176 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.Engine) 

'SemVersion.operator >=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 176 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.Engine) 

'SemVersion.operator >=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 176 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.EngineTest, 6.0.x) 

'SemVersion.operator >=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 176 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.FlagsmithClient) 

'SemVersion.operator >=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 176 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.FlagsmithClient) 

'SemVersion.operator >=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 176 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.Client.Test) 

'SemVersion.operator >=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 176 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.Client.Test) 

'SemVersion.operator >=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 176 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.EngineTest) 

'SemVersion.operator >=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 176 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.EngineTest) 

'SemVersion.operator >=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 176 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.EngineTest, 7.0.x) 

'SemVersion.operator >=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 176 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.Client.Test, 6.0.x) 

'SemVersion.operator >=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 176 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.Client.Test, 7.0.x) 

'SemVersion.operator >=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 176 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.Client.Test, 8.0.x) 

'SemVersion.operator >=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'
case Constants.LessThan: return traitValueAsVersion < conditionValueAsVersion;

Check warning on line 177 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.EngineTest, 8.0.x) 

'SemVersion.operator <(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 177 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.Engine) 

'SemVersion.operator <(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 177 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.Engine) 

'SemVersion.operator <(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 177 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.EngineTest, 6.0.x) 

'SemVersion.operator <(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 177 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.FlagsmithClient) 

'SemVersion.operator <(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 177 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.FlagsmithClient) 

'SemVersion.operator <(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 177 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.Client.Test) 

'SemVersion.operator <(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 177 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.Client.Test) 

'SemVersion.operator <(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 177 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.EngineTest) 

'SemVersion.operator <(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 177 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.EngineTest) 

'SemVersion.operator <(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 177 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.EngineTest, 7.0.x) 

'SemVersion.operator <(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 177 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.Client.Test, 6.0.x) 

'SemVersion.operator <(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 177 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.Client.Test, 7.0.x) 

'SemVersion.operator <(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 177 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.Client.Test, 8.0.x) 

'SemVersion.operator <(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'
case Constants.LessThanInclusive: return traitValueAsVersion <= conditionValueAsVersion;

Check warning on line 178 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.EngineTest, 8.0.x) 

'SemVersion.operator <=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 178 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.Engine) 

'SemVersion.operator <=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 178 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.Engine) 

'SemVersion.operator <=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 178 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.EngineTest, 6.0.x) 

'SemVersion.operator <=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 178 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.FlagsmithClient) 

'SemVersion.operator <=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 178 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.FlagsmithClient) 

'SemVersion.operator <=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 178 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.Client.Test) 

'SemVersion.operator <=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 178 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.Client.Test) 

'SemVersion.operator <=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 178 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.EngineTest) 

'SemVersion.operator <=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 178 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Check Build and formatting (Flagsmith.EngineTest) 

'SemVersion.operator <=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 178 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.EngineTest, 7.0.x) 

'SemVersion.operator <=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 178 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.Client.Test, 6.0.x) 

'SemVersion.operator <=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 178 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.Client.Test, 7.0.x) 

'SemVersion.operator <=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'

Check warning on line 178 in Flagsmith.Engine/Segment/Evaluator.cs

GitHub Actions / Test (Flagsmith.Client.Test, 8.0.x) 

'SemVersion.operator <=(SemVersion, SemVersion)' is obsolete: 'Operator is obsolete. Use CompareSortOrder() or ComparePrecedence() instead.'
default: throw new ArgumentException("Invalid Operator");
}
}