Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix testing workflow #132

Merged
merged 13 commits into from
Jan 14, 2025
Merged

ci: fix testing workflow #132

merged 13 commits into from
Jan 14, 2025

Conversation

matthewelwell
Copy link
Contributor

@matthewelwell matthewelwell commented Jan 14, 2025

Ok, so this PR was born out of issues seen primarily in #130.

I'm still not entirely sure why the workflows suddenly stopped working, but I suspect it has something to do with an upgrade on the github side which removed .net6.0 from the machines as a default.

This PR does the following:

  1. Adds .net6.0 explicitly to the test workflow alongside the matrix version. I actually am not sure at this point which version the tests are actually run against based on this, but it gets them passing for now.
  2. After doing this, I had to remove the global.json, and hence update release.yml. I can't really see how the global.json file ever worked with the matrix logic for the test workflow.

We should, in the near future, drop support for .net6.0 and major version the client, but I first want to get #130 out of the door and this is a quick win to get that done.

@matthewelwell matthewelwell changed the title ci: temporarily remove matrix from testing workflow ci: fix testing workflow Jan 14, 2025
@matthewelwell matthewelwell merged commit 5f1462c into main Jan 14, 2025
10 checks passed
@matthewelwell matthewelwell deleted the ci/fix-workflows branch January 14, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants