This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
Refactor bikelane categories, cleanup area code
#137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same pattern as BikelanesTodos
1 task
Some of the comments here are from 2b135c8 and in fact wrong. We want all living streets as bike friendly category. But we want to filter 1. when all vehicles except bikes are prohibited 2. when bikes are prohibited explicitly
rush42
pushed a commit
to FixMyBerlin/atlas-app
that referenced
this pull request
Jul 15, 2024
…geo#137) - refactor bikelane categories to use a more class like pattern - check and update comments per category (some are todo) - add some todos where things need to be checked - the area stuff was confusing and is cleaned up now Ping FixMyBerlin/private-issues#1664
rush42
pushed a commit
to FixMyBerlin/atlas-app
that referenced
this pull request
Jul 15, 2024
…geo#137) - refactor bikelane categories to use a more class like pattern - check and update comments per category (some are todo) - add some todos where things need to be checked - the area stuff was confusing and is cleaned up now Ping FixMyBerlin/private-issues#1664
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping https://github.com/FixMyBerlin/private-issues/issues/1664