Todos: Introduce RoadTodos

processing/topics/roads_bikelanes/roads/RoadTodos.lua

@@ -0,0 +1,43 @@
+package.path = package.path .. ";/processing/topics/helper/?.lua"
+require('RemoveNilValues')
+RoadTodo = {}
+RoadTodo.__index = RoadTodo
+
+-- @param args table
+-- @param args.key string
+-- @param args.desc string
+-- @param args.conditions function
+function RoadTodo.new(args)
+  local self = setmetatable({}, RoadTodo)
+  self.key = args.key
+  self.desc = args.desc
+  self.conditions = args.conditions
+  return self
+end
+
+function RoadTodo:checkCondition(objectTags, resultTags)
+  if self.conditions(objectTags, resultTags) then
+    return self.key
+  else
+    return nil
+  end
+end
+
+-- === Fahrradstraßen ===
+local check_cycleway_shared = RoadTodo.new({
+  key = "check_cycleway_shared",
+  desc = "Tagging `cycleway=shared` is very old tagging and should be checked an maybe removed.",
+  conditions = function(tagsObject, _)
+    return tagsObject.cycleway == "shared"
+  end
+})
+
+
+-- Public funtion
+function RoadTodos(tagsObject, resultTags)
+  local todos = {}
+
+  todos[#todos + 1] = check_cycleway_shared:checkCondition(tagsObject, resultTags)
+
+  return RemoveNilValues(todos)
+end

processing/topics/roads_bikelanes/roads_bikelanes.lua

@@ -28,6 +28,7 @@ require("ExtractPublicTags")
 require("Round")
 require("DefaultId")
 require("PathsGeneralization")
+require("RoadTodos")
 
 local roadsTable = osm2pgsql.define_table({
   name = 'roads',
@@ -134,6 +135,7 @@ function osm2pgsql.process_way(object)
     MergeTable(results, Maxspeed(object))
   end
   MergeTable(results, BikelanesPresence(object, cycleways))
+  results.todos = ToMarkdownList(RoadTodos(tags, results))
 
   -- We need sidewalk for Biklanes(), but not for `roads`
   if not IsSidepath(tags) then