Improve behaviour when clicking on tagger. #37
Conversation
Clicking on any area of whitespace within the tagger, including the input field, will now trigger the suggestion list in both single and multi select mode. In single-select mode, clicking on the selected tag will also trigger the suggestion list. When clearing the selected tag in single-select mode via the (x), the suggestions list remain open if it is currently open, and the filter value (if there is one) will be moved to the main input so that filtering can continue seamlessly.
|
Is it a good idea to show the full unfiltered list on click? |
|
You make a good point, but it's ultimately doing the same thing as pressing the dropdown arrow (loading up to 300 immediately if not already initialised). I guess it does make it slightly worse because it removes the opportunity to filter before the list is shown. We should do something along the lines of your latter suggestion and load fewer items initially. I was planning to take a look at the logic around that stuff in a follow-up set of changes anyway. I'm not a big fan of pseudo-infinite scrolling, but we could certainly load the list in a more deliberately async way. |
|
I've filed #38, #39 and #40 to look at a few areas of performance. I'll update this pull request to disable the functionality for multi-select and single-select taggers where no value has yet been chosen (for now). My main goal currently is to allow users to click on a single-select tagger and have the menu drop-down, which achieves feature parity with native HTML select widgets. This essentially just extends the hit target from the drop-down arrow only to the whole widget if a value has already been selected. |
For performance reasons, only display the suggestions list if we click on the tagger and it has a single value selected (in single value mode). Functionality to display the suggestion menu on click may be restored later for multi select or single-select with no value when performance of generating the suggestion list has been improved.
|
@Palmr - pull request updated as above. |
Improve behaviour when clicking on tagger.
Clicking on any area of whitespace within the tagger, including the
input field, will now trigger the suggestion list in both single and
multi select mode. In single-select mode, clicking on the selected tag
will also trigger the suggestion list.
When clearing the selected tag in single-select mode via the (x), the
suggestions list remain open if it is currently open, and the filter
value (if there is one) will be moved to the main input so that
filtering can continue seamlessly.
Solves #10.