Verify loaders exist at build. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes ScriptRunner to raise an exception rather than log a warning when files are found in the source directory that are not implicated in the manifest.
This add a flag to the -build process to ensure that all the referenced Loaders exist at build time.
… base directory is the source directory.
…ust the first one found.
switchtrue
changed the title
Closed
|
Thanks Mike! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #5. Supersedes #11
Added the new -verifyloaders flag that will validate that the Loader files references in the manifest can be found at build time.
@Palmr I'm not sure 100% on how you do your build. Our ScriptRunner.jar and ScriptRunner directory live inside the source directory so the Loaders should always be resolvable at build time. I'm not sure if this is true for you. As such I have only made it validate if you pass the new flag. However, I can make it always do a warning if you like and only error if you pass this flag - much like my implementation for -nounimplicatedfiles.