Local relay implementation #182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hexxeh
reviewed
Nov 17, 2021
Hexxeh
reviewed
Nov 17, 2021
Hexxeh
reviewed
Nov 17, 2021
Hexxeh
reviewed
Nov 17, 2021
Hexxeh
reviewed
Nov 17, 2021
Signed-off-by: Rafael Sofi-zada <[email protected]>
rafasofizada
force-pushed
the
local-relay-impl
branch
from
91d1135 to
fe00d51
Compare
Hexxeh
reviewed
Nov 18, 2021
Hexxeh
reviewed
Nov 18, 2021
Hexxeh
reviewed
Nov 18, 2021
Hexxeh
reviewed
Nov 18, 2021
|
I see there's some CI issues and unresolved comments, ping me via a comment once this is ready for review. Also I sent you some info via hangouts. :) |
Signed-off-by: Rafael Sofi-zada <[email protected]>
Signed-off-by: Rafael Sofi-zada <[email protected]>
Signed-off-by: Rafael Sofi-zada <[email protected]>
Signed-off-by: Rafael Sofi-zada <[email protected]>
Signed-off-by: Rafael Sofi-zada <[email protected]>
Lots of lines shown as "uncovered" in the coverage report actually are; don't know how to make it noticeable for jest Signed-off-by: Rafael Sofi-zada <[email protected]>
canConnectPeer should answer the question straightforward – is it possible to connect a peer or not? Not having an existing connection means "false", and doesn't warrant an exception. Exceptions make sense in connectPeer() – there throwing an exception on non-existent connection makes sense. Signed-off-by: Rafael Sofi-zada <[email protected]>
Signed-off-by: Rafael Sofi-zada <[email protected]>
Signed-off-by: Rafael Sofi-zada <[email protected]>
Signed-off-by: Rafael Sofi-zada <[email protected]>
Signed-off-by: Rafael Sofi-zada <[email protected]>
Signed-off-by: Rafael Sofi-zada <[email protected]>
rafasofizada
force-pushed
the
local-relay-impl
branch
from
07f5e18 to
88084e1
Compare
Hexxeh
reviewed
Nov 23, 2021
Signed-off-by: Rafael Sofi-zada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rafasofizada [email protected]