Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VONK-5093: introducing IScopedNode #2582

Merged
merged 16 commits into from
Dec 11, 2023

Conversation

marcovisserFurore
Copy link
Member

@marcovisserFurore marcovisserFurore commented Sep 6, 2023

Description

In this pull request (PR), we are introducing the IScopedNode interface, a derivative of IBaseElementNavigator. Essentially, it mirrors ITypedElement but excludes the location and definition members.

The purpose of this new IScopedNode interface is its integration into the upcoming validator and potentially into FhirPath at a later stage.

Issue

This PR resolves VONK-5093.

Remarks

  • This is the time to think about the naming of the interface IScopedNode and IBaseElementNavigator

@marcovisserFurore marcovisserFurore marked this pull request as ready for review November 14, 2023 14:12
@ewoutkramer
Copy link
Member

Writing down some ideas....

IBaseNavigator = IElementNavigator
IScopedNode = IElementNode

IBaseNavigator = IElementNode
IScopedNode =IElementTreeNode

@marcovisserFurore marcovisserFurore merged commit 7aac259 into develop Dec 11, 2023
15 checks passed
@marcovisserFurore marcovisserFurore deleted the feature/VONK-5093-IScopedNode branch December 11, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants