Fix the return types of dot4add_i8packed and dot4add_u8packed.
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teoxoy
approved these changes
Apr 30, 2025
jimblandy
force-pushed
the
fx-dot4add-packed-return-type
branch
from
5644b96 to
5f04faf
Compare
Change the definition of the HLSL `dot4add_i8packed`,
`dot4add_u8packed`, and `dot2add` intrinsics in
`utils/hct/gen_intrin_main.txt` to simply spell out the return types,
rather than saying that their return type is determined by their third
argument.
This prevents DXC from trying to give those functions declarations like
declare i64 @"\01?dot4add_u8packed@hlsl@@YA_JII_J@Z"(i32, i32, i64 signext) microsoft#1
which seems to expect a 64-bit third argument and return value.
`HLSLExternalSource::MatchArguments` assumes that functions whose
return type depends on their arguments' types will get cleaned up by
`TryEvalInstrinsic`. Unfortunately, the `dot4add` variants cannot be
constant expressions, so this cleanup does not happen for them. But
these functions are not generic, and they have only one overload, so
there is no need to use interesting `uComponentTypeId` values to get
the right effects in the first place.
Fixes microsoft#7400.
jimblandy
force-pushed
the
fx-dot4add-packed-return-type
branch
from
5f04faf to
f895647
Compare
|
This has been approved here and merged upstream, so I'm going to merge it here, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the definition of the HLSL
dot4add_i8packedanddot4add_u8packedintrinsics inutils/hct/gen_intrin_main.txtto simply spell out the return types, rather than saying that their return type is determined by their third argument.This prevents DXC from trying to give those functions declarations like
which seems to expect a 64-bit third argument and return value.
These functions are not generic, and they have only one overload, so there is no need to use interesting
uComponentTypeIdvalues to get the right effects, andHLSLExternalSource::MatchArgumentsseems to get confused about how to treat argument types that affect the return types.