Fix for #8249 #8270
Fix for #8249 #8270
Conversation
|
Let's please write more details in commit messages. A reference to a ticket is not enough IMO. Ticket describes WHAT is fixed but a commit message should describe HOW it was fixed. |
src/isql/isql.epp
Outdated
| @@ -9597,33 +9597,24 @@ static const char* charset_to_string(unsigned charset) | |||
| **************************************/ | |||
| static Firebird::GlobalPtr<Firebird::GenericMap<Firebird::Pair<Firebird::Right<unsigned, string> > > > csMap; | |||
|
|
|||
| charset = TTYPE_TO_CHARSET(charset); | |||
There was a problem hiding this comment.
What is the relation of this isql changes with #8249 ?
There was a problem hiding this comment.
QA team and me should have a way to check field collation to make sure that #8249 really fixed and result of the CAST() has the right collation. The simplest way - to print collation in SQLDA along to the charset. That's why this change.
There was a problem hiding this comment.
First, ISQL showed the charset/collation id, so it was identifiable.
You want to display also the collation name, but this change makes it incorrectly. Collation ids, different from charset ids, are far from be stable between different databases. I suggest to revert this part of the patch.
It is written in code: |
src/isql/isql.epp
Outdated
| @@ -9597,33 +9597,24 @@ static const char* charset_to_string(unsigned charset) | |||
| **************************************/ | |||
| static Firebird::GlobalPtr<Firebird::GenericMap<Firebird::Pair<Firebird::Right<unsigned, string> > > > csMap; | |||
|
|
|||
| charset = TTYPE_TO_CHARSET(charset); | |||
There was a problem hiding this comment.
First, ISQL showed the charset/collation id, so it was identifiable.
You want to display also the collation name, but this change makes it incorrectly. Collation ids, different from charset ids, are far from be stable between different databases. I suggest to revert this part of the patch.
No description provided.