Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ru_ru.json #275

Open
wants to merge 4 commits into
base: 20.1/forge
Choose a base branch
from
Open

Create ru_ru.json #275

wants to merge 4 commits into from

Conversation

mpustovoi
Copy link

@mpustovoi mpustovoi commented May 1, 2024 •
edited
Loading

Both Sodium and Embeddium lang folders
Most of the translations for the Sodium folder are provided by the Translations for Sodium resource pack

mpustovoi added 2 commits May 1, 2024 21:25
@mpustovoi
Create ru_ru.json
9ffe122 
`Sodium` lang folder
@mpustovoi
Create ru_ru.json
fa77560 
`Embeddium` lang folder
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024 •
edited
Loading

DCO Assistant Lite bot All contributors have read and affirmed the entire contents of the Developer Certificate of Origin.

@mpustovoi
Copy link
Author

I have read, and hereby affirm the entire contents of the Developer Certificate of Origin.

embeddedt
embeddedt suggested changes May 1, 2024
View reviewed changes
Copy link
Contributor

@embeddedt embeddedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The strings in the sodium/lang file need to mention Embeddium (even though the key is still sodium), except for sodium.options.buttons.donate. That one should be left as-is.

@mpustovoi mpustovoi requested a review from embeddedt May 1, 2024 18:56
embeddedt
embeddedt approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@embeddedt embeddedt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. We are still sorting out how we want to handle the logistics of translations for the original Sodium strings going forward, hence the delay in merging.

@mpustovoi
Update ru_ru.json
561c7c3 
Added new lines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embeddedt embeddedt embeddedt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpustovoi @embeddedt