This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
S3: enable overriding x-amz-date from signing server #2021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the changes
AWS S3 SDK using PostObjectV4 (https://docs.aws.amazon.com/aws-sdk-php/v3/api/class-Aws.S3.PostObjectV4.html) doesnt let you set custom date for policy, and sometimes the dates are different about a second, so the better way for me is setting the date from server.
Maybe even better way would be setting the whole
awsParams
from server.What browsers and operating systems have you tested these changes on?
macos chrome
Have you written unit tests? If not, explain why.
I didnt find existing matching test for this.