fix(uploader.basic.api.js): file marked as retrying too late

Should happen before the wait period, not after. fixes #1670
FineUploader · Nov 6, 2016 · 9c0a312 · 9c0a312
1 parent 5fb466b
commit 9c0a312
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/client/js/uploader.api.js b/client/js/uploader.api.js
@@ -255,7 +255,7 @@
                 }
             }
 
-            if (newStatus === qq.status.UPLOAD_RETRYING) {
+            if (oldStatus === qq.status.UPLOAD_RETRYING && newStatus === qq.status.UPLOADING) {
                 this._templating.hideRetry(id);
                 this._templating.setStatusText(id);
                 qq(this._templating.getFileContainer(id)).removeClass(this._classes.retrying);

diff --git a/client/js/uploader.basic.api.js b/client/js/uploader.basic.api.js
@@ -1313,21 +1313,23 @@
             self._preventRetries[id] = responseJSON[self._options.retry.preventRetryResponseProperty];
 
             if (self._shouldAutoRetry(id, name, responseJSON)) {
+                var retryWaitPeriod = self._options.retry.autoAttemptDelay * 1000;
+
                 self._maybeParseAndSendUploadError.apply(self, arguments);
                 self._options.callbacks.onAutoRetry(id, name, self._autoRetries[id]);
                 self._onBeforeAutoRetry(id, name);
 
+                self._uploadData.setStatus(id, qq.status.UPLOAD_RETRYING);
                 self._retryTimeouts[id] = setTimeout(function() {
-                    self.log("Retrying " + name + "...");
-                    self._uploadData.setStatus(id, qq.status.UPLOAD_RETRYING);
+                    self.log("Starting retry for " + name + "...");
 
                     if (callback) {
                         callback(id);
                     }
                     else {
                         self._handler.retry(id);
                     }
-                }, self._options.retry.autoAttemptDelay * 1000);
+                }, retryWaitPeriod);
 
                 return true;
             }