Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert changes to components not being upgraded #1963

Merged

Conversation

frshwtr
Copy link
Contributor

@frshwtr frshwtr commented Feb 11, 2025

Describe your changes

Reverts changes in deprecated components:

  • o-typography
  • o-visual-effects

Reverts linting changes by components unaffected by migration, this is to save releasing them as a big release:

  • o-colors
  • o-icons
  • o-spacing

Issue ticket number and link

Link to Figma designs

Checklist before requesting a review

  • I have applied percy label for o-[COMPONENT] or chromatic label for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md
  • If it is a new feature, I have added thorough tests.
  • I have updated relevant docs.
  • I have updated relevant env variables in Doppler.

@notlee notlee temporarily deployed to origami-webs-2025-relea-cqj8kj February 11, 2025 13:47 Inactive
@notlee notlee temporarily deployed to origami-webs-2025-relea-cqj8kj February 11, 2025 15:06 Inactive
@frshwtr frshwtr changed the title fix: revert o-typography changes fix: revert changes to components not being upgraded Feb 11, 2025
@frshwtr frshwtr marked this pull request as ready for review February 11, 2025 15:12
Copy link
Member

@j-mes j-mes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I ran the tests locally for o-colors, o-icons and o-spacing. It all passes. I think the brownout for the old actions/v2 can be fixed at a later date (before 1st March).

Could double-confirm by rerunning the tests tomorrow when the brownout is turned off?

@j-mes
Copy link
Member

j-mes commented Feb 12, 2025

🎉 No brownout effect @frshwtr

@frshwtr frshwtr merged commit bd27cfd into 2025-release Feb 12, 2025
9 checks passed
@frshwtr frshwtr deleted the 2025-release-revert-unexpected-component-changes branch February 12, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants