Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OR-1212]: o-labels failing tests #1937

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[OR-1212]: o-labels failing tests #1937

merged 1 commit into from
Jan 17, 2025

Conversation

j-mes
Copy link
Member

@j-mes j-mes commented Jan 17, 2025 •
edited by jira bot
Loading

Describe your changes

Update the tests to use colours from rgb with decimals. See W3.org for an explainer why to use this ahead of normal rgb or hex values.

Issue ticket number and link

OR-1212

Link to Figma designs

N/A

Checklist before requesting a review

  • I have applied percy label for o-[COMPONENT] or chromatic label for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md
  • If it is a new feature, I have added thorough tests.
  • I have updated relevant docs.
  • I have updated relevant env variables in Doppler.

@notlee notlee temporarily deployed to origami-webs-or-1212-o--8kcfqc January 17, 2025 13:00 Inactive
@j-mes j-mes marked this pull request as ready for review January 17, 2025 13:45
@j-mes j-mes requested a review from a team as a code owner January 17, 2025 13:45
@j-mes j-mes merged commit 4d21116 into main Jan 17, 2025
8 checks passed
@j-mes j-mes deleted the OR-1212-o-labels-failing-test branch January 17, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frshwtr frshwtr frshwtr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-mes @frshwtr @notlee