chore: Add further new type usecases [OR-1205] #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlee
changed the title
Base automatically changed from
2025-release-type-usecase-display
to
2025-release
January 13, 2025 13:42
frshwtr
reviewed
Jan 13, 2025
apps/for-everyone-website/src/content/docs/guides/typography.mdx
Outdated
Show resolved
Hide resolved
frshwtr
reviewed
Jan 13, 2025
apps/for-everyone-website/src/content/docs/guides/typography.mdx
Outdated
Show resolved
Hide resolved
frshwtr
reviewed
Jan 13, 2025
|
|
||
| We use multiple typographic scales for different font families. Our scale ranges from -3 to 10, depending on the font family. Consider scale 0 the baseline, with ascending and descending values in each direction. Avoid using styles below zero for long form content. | ||
| Typography use-cases provide low level typography styles for use in a variety of contexts. In addition to these general type style, Origami provides typography components which use these. For example the [display component](#) combines all three [display sizes](#display) at different breakpoints for a responsive heading. |
There was a problem hiding this comment.
[display component] links to the top of this page. I am unsure what content this is supposed to be directing me to.
There was a problem hiding this comment.
Good spot 😄 That content doesn't exist yet. When we've done updating components OR-1193 let's do a solid review of the docs
frshwtr
reviewed
Jan 13, 2025
| .o3-typography-link, | ||
| .o3-typography-wrapper > a, | ||
| .o3-typography-wrapper > p > a { | ||
| :where([data-o3-brand] a) { |
There was a problem hiding this comment.
does this also need where([class^='o3-typography']) like in components/o3-foundation/src/css/components/Typography/index.css?
There was a problem hiding this comment.
Good question but no. The intention here :where([data-o3-brand] a) is to style any link on the page that has o3 applied (where keep specificity low), effectively a global style but actually scoped to o3. On the other hand where([class^='o3-typography']) applies to any element with an o3-type class
frshwtr
reviewed
Jan 13, 2025
components/o3-foundation/src/css/components/Typography/usecases.css
Outdated
Show resolved
Hide resolved
|
There's an error when running o3-storybook: |
notlee
commented
Jan 13, 2025
components/o3-foundation/src/css/components/Typography/usecases.css
Outdated
Show resolved
Hide resolved
Skip link usescases. It adds an underline to the body-base style, but not the colours or interactive states we'd associate with a link. We don't have a similar style for a link within body-lg which suggests we don't expect links in those contexts? From an engineering perspective I'd have body-base or body-lg classes, and any link within would have colour and an underline for the different states (hover, etc). Unsure how to represent this in Figma helpfully for designers except for providing a link component, which doesn't help with applying a link style within a body of text. Waiting for feedback from design.
…aphy.mdx Co-authored-by: Ben Freshwater <[email protected]>
…usecases.css Delete duplicate declaration
notlee
force-pushed
the
2025-release-type-usecase-the-rest
branch
from
67aae04 to
b7d2372
Compare
frshwtr
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip link usescases. It adds an underline to the body-base style, but not the colours or interactive states we'd associate with a link. We don't have a similar style for a link within body-lg which suggests we don't expect links in those contexts? From an engineering perspective I'd have body-base or body-lg classes, and any link within would have colour and an underline for the different states (hover, etc). Unsure how to represent this in Figma helpfully for designers except for providing a link component, which doesn't help with applying a link style within a body of text. Waiting for feedback from design.