Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update o3 icons #1903

Merged
merged 12 commits into from
Dec 18, 2024
Merged

feat: update o3 icons #1903

merged 12 commits into from
Dec 18, 2024

Conversation

frshwtr
Copy link
Contributor

@frshwtr frshwtr commented Dec 17, 2024

Describe your changes

Issue ticket number and link

Link to Figma designs

Checklist before requesting a review

  • I have applied percy label for o-[COMPONENT] or chromatic label for o3-[COMPONENT] on my PR before merging and after review. Find more details in CONTRIBUTING.md
  • If it is a new feature, I have added thorough tests.
  • I have updated relevant docs.
  • I have updated relevant env variables in Doppler.

@frshwtr frshwtr requested a review from a team as a code owner December 17, 2024 14:03
@notlee notlee temporarily deployed to origami-webs-or-1097-in-naylg8 December 17, 2024 14:07 Inactive
@notlee
Copy link
Contributor

notlee commented Dec 17, 2024

Thanks @frshwtr! These also need to be renamed for o3. Mary detailed the new names here: https://financialtimes.atlassian.net/browse/OR-1098?focusedCommentId=880559

@notlee
Copy link
Contributor

notlee commented Dec 17, 2024

I would also expect libraries/o3-tooling-token/build/icons/_variables.js to have updated, and the icons to show on the website 🤔 Did you run npm run build -w apps/dictionary/?

@notlee notlee temporarily deployed to origami-webs-or-1097-in-naylg8 December 17, 2024 14:47 Inactive
notlee
notlee requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@notlee notlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming as above 🙇

@notlee notlee temporarily deployed to origami-webs-or-1097-in-naylg8 December 17, 2024 15:31 Inactive
@notlee notlee temporarily deployed to origami-webs-or-1097-in-naylg8 December 17, 2024 15:40 Inactive
@notlee notlee temporarily deployed to origami-webs-or-1097-in-naylg8 December 17, 2024 15:45 Inactive
@notlee notlee temporarily deployed to origami-webs-or-1097-in-naylg8 December 17, 2024 15:57 Inactive
@notlee notlee temporarily deployed to origami-webs-or-1097-in-naylg8 December 18, 2024 10:21 Inactive
@notlee notlee temporarily deployed to origami-webs-or-1097-in-naylg8 December 18, 2024 10:25 Inactive
@notlee notlee temporarily deployed to origami-webs-or-1097-in-naylg8 December 18, 2024 10:27 Inactive
@notlee notlee self-requested a review December 18, 2024 10:34
@notlee notlee temporarily deployed to origami-webs-or-1097-in-naylg8 December 18, 2024 10:35 Inactive
@notlee notlee merged commit 2797201 into main Dec 18, 2024
15 checks passed
@notlee notlee deleted the or-1097/introduce-new-o3-tokens branch December 18, 2024 11:59
@notlee notlee mentioned this pull request Dec 18, 2024
Merged
@notlee notlee restored the or-1097/introduce-new-o3-tokens branch December 18, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notlee notlee notlee approved these changes

@ft-dependency-auto-merger ft-dependency-auto-merger Awaiting requested review from ft-dependency-auto-merger ft-dependency-auto-merger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frshwtr @notlee