Stop error from google ads sdk spamming sentry (#121)

* Stop error from google ads sdk spamming sentry * Static method * Fixed tests * OOps
Financial-Times · Jun 8, 2018 · 166e5a2 · 166e5a2
1 parent 552b940
commit 166e5a2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/src/js/ads.js b/src/js/ads.js
@@ -21,7 +21,7 @@ class VideoAds {
 		this.adsCompleted = false;
 	}
 
-	loadAdsLibrary() {
+	static loadAdsLibrary() {
 		return new Promise((resolve, reject) => {
 			let googleSdkScript = document.querySelector('[src="//imasdk.googleapis.com/js/sdkloader/ima3.js"]');
 
@@ -43,7 +43,6 @@ class VideoAds {
 				});
 
 				googleSdkScript.addEventListener('error', (e) => {
-					this.reportError(e);
 					reject(e);
 				});
 			}

diff --git a/src/js/video.js b/src/js/video.js
@@ -201,7 +201,7 @@ class Video {
 	}
 
 	init() {
-		return (this.opts.advertising ? this.videoAds.loadAdsLibrary() : Promise.resolve())
+		return (this.opts.advertising ? VideoAds.loadAdsLibrary() : Promise.resolve())
 			.catch(() => {
 				// If ad doesn't load for some reason, load video as normal
 				this.opts.advertising = false;

diff --git a/test/ads.test.js b/test/ads.test.js
@@ -40,7 +40,7 @@ describe('Ads', () => {
 	});
 
 	it('should add the video advertising script if the configuration parameter is passed', () => {
-		return ads.loadAdsLibrary()
+		return Ads.loadAdsLibrary()
 			.then(() => {
 				proclaim.ok(document.querySelector('[src="//imasdk.googleapis.com/js/sdkloader/ima3.js"]'));
 			});