Skip to content

Commit

Permalink
Merge pull request #26 from Financial-Times/upgrade-repo-to-node-v-12
Browse files Browse the repository at this point in the history
Upgrade from Node 8 to Node 12
  • Loading branch information
NickColley authored Apr 27, 2021
2 parents 65165f2 + 47e1e93 commit c1a166a
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 11 deletions.
22 changes: 11 additions & 11 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@

references:

container_config_node8: &container_config_node8
container_config_node: &container_config_node
working_directory: ~/project/build
docker:
- image: circleci/node:8-browsers
- image: circleci/node:12-browsers

container_config_lambda_node8: &container_config_lambda_node8
container_config_lambda_node: &container_config_lambda_node
working_directory: ~/project/build
docker:
- image: lambci/lambda:build-nodejs8.10
- image: lambci/lambda:build-nodejs12.x

workspace_root: &workspace_root
~/project
Expand All @@ -22,13 +22,13 @@ references:

npm_cache_keys: &npm_cache_keys
keys:
- v10-dependency-npm-{{ checksum "package.json" }}-
- v10-dependency-npm-{{ checksum "package.json" }}
- v10-dependency-npm-
- v11-dependency-npm-{{ checksum "package.json" }}-
- v11-dependency-npm-{{ checksum "package.json" }}
- v11-dependency-npm-

cache_npm_cache: &cache_npm_cache
save_cache:
key: v10-dependency-npm-{{ checksum "package.json" }}-{{ epoch }}
key: v11-dependency-npm-{{ checksum "package.json" }}-{{ epoch }}
paths:
- ./node_modules/

Expand Down Expand Up @@ -60,7 +60,7 @@ version: 2
jobs:

build:
<<: *container_config_node8
<<: *container_config_node
steps:
- checkout
- run:
Expand Down Expand Up @@ -93,7 +93,7 @@ jobs:
- build

test:
<<: *container_config_node8
<<: *container_config_node
steps:
- *attach_workspace
- run:
Expand All @@ -109,7 +109,7 @@ jobs:
destination: test-results

publish:
<<: *container_config_node8
<<: *container_config_node
steps:
- *attach_workspace
- run:
Expand Down
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,8 @@
"commitmsg": "node_modules/.bin/secret-squirrel-commitmsg",
"prepush": "make verify -j3",
"prepare": "npx snyk protect || npx snyk protect -d || true"
},
"engines": {
"node": "12.x"
}
}

0 comments on commit c1a166a

Please sign in to comment.