Merge pull request #158 from Financial-Times/log-null-data-in-graphit…

…ethreshold-check [NOPS-985] Log null data in GraphiteThreshold check
Financial-Times · Sep 1, 2021 · a8a714f · a8a714f
2 parents b0cc8e3 + 3ae482e
commit a8a714f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/checks/graphiteThreshold.check.js b/src/checks/graphiteThreshold.check.js
@@ -50,6 +50,10 @@ class GraphiteThresholdCheck extends Check {
 					if (value[0] === null) {
 						// metric data is unavailable, we don't fail this threshold check if metric data is unavailable
 						// if you want a failing check for when metric data is unavailable, use graphiteWorking
+						logger.info({
+							event: `${logEventPrefix}_NULL_DATA`,
+							url: this.sampleUrl,
+						});
 						return false;
 					} else {
 						return this.direction === 'above' ?

diff --git a/test/graphiteThreshold.check.spec.js b/test/graphiteThreshold.check.spec.js
@@ -9,6 +9,13 @@ function getCheckConfig (conf) {
 	return Object.assign({}, fixture, conf || {});
 }
 
+const mockLogger = {
+	default: {
+		error: function() {},
+		info: function() {},
+	}
+}
+
 let mockFetch;
 let Check;
 
@@ -21,7 +28,10 @@ function mockGraphite (results) {
 		json : () => Promise.resolve(results)
 	}));
 
-	Check = proxyquire('../src/checks/graphiteThreshold.check', {'node-fetch':mockFetch});
+	Check = proxyquire('../src/checks/graphiteThreshold.check', {
+		'@financial-times/n-logger': mockLogger,
+		'node-fetch': mockFetch,
+	});
 }
 
 describe('Graphite Threshold Check', function(){