Merge pull request #129 from Financial-Times/upgrade-to-node-12

Upgrade to Node v12
Financial-Times · Oct 2, 2020 · 20595a8 · 20595a8
2 parents 17ff69b + c0b4241
commit 20595a8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -3,10 +3,10 @@
 
 references:
 
-  container_config_node8: &container_config_node8
+  container_config_node12: &container_config_node12
     working_directory: ~/project/build
     docker:
-      - image: circleci/node:8-browsers
+      - image: circleci/node:12-browsers
 
   workspace_root: &workspace_root
     ~/project
@@ -67,7 +67,7 @@ commands:
 jobs:
 
   build:
-    <<: *container_config_node8
+    <<: *container_config_node12
     steps:
       - checkout
       - run:
@@ -97,7 +97,7 @@ jobs:
             - build
 
   test:
-    <<: *container_config_node8
+    <<: *container_config_node12
     steps:
       - *attach_workspace
       - run:
@@ -113,7 +113,7 @@ jobs:
           destination: test-results
 
   publish:
-    <<: *container_config_node8
+    <<: *container_config_node12
     steps:
       - *attach_workspace
       - run:

diff --git a/.nvmrc b/.nvmrc
@@ -0,0 +1 @@
+12
diff --git a/package.json b/package.json
@@ -14,7 +14,7 @@
     "prepare": "npx snyk protect || npx snyk protect -d || true"
   },
   "engines": {
-    "node": "^4.0.0"
+    "node": "12.x"
   },
   "repository": {
     "type": "git",