Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backstage: disallow chore commits, introduce backstage commits #659

Merged
merged 1 commit into from
May 29, 2024
Merged

backstage: disallow chore commits, introduce backstage commits #659

merged 1 commit into from
May 29, 2024

Conversation

apaleslimghost
Copy link
Member

@apaleslimghost apaleslimghost requested a review from a team as a code owner May 29, 2024 09:20
ivomurrell
ivomurrell approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@ivomurrell ivomurrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!! i hate chore!!

joelcarr
joelcarr reviewed May 29, 2024
View reviewed changes
Copy link
Member

@joelcarr joelcarr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore: backstage: We should add documentation to mention these are the prefixes we support.

@cerdfied
Copy link

chore: backstage: We should add documentation to mention these are the prefixes we support.

agreed, we should probably add something here like in content-pipeline

@apaleslimghost apaleslimghost force-pushed the apaleslimghost-patch-2 branch from 04ef8c3 to 254982b Compare May 29, 2024 11:05
@apaleslimghost apaleslimghost merged commit 1934be7 into main May 29, 2024
17 checks passed
@apaleslimghost apaleslimghost deleted the apaleslimghost-patch-2 branch May 29, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelcarr joelcarr joelcarr left review comments

@cerdfied cerdfied cerdfied approved these changes

@ivomurrell ivomurrell ivomurrell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apaleslimghost @cerdfied @joelcarr @ivomurrell