change nested stack template to v2 #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaleslimghost
requested changes
May 24, 2024
There was a problem hiding this comment.
hi Hamza, thanks for the PR! we use release-please and Conventional Commits, so for this to be releasable you'll need to prefix the commit message with feat:
|
also please note that this template is only used when setting up new repos with Tool Kit, we'll also need to update existing repos, will you be working on that? |
hamza-samih
force-pushed
the
migrate-to-nested-stack-role-v2
branch
from
2b2676f to
c20ac93
Compare
|
Thanks @apaleslimghost i've amended the commit message to comply with release-please. R.e updating existing repo's, we've done this already in nearly all aws-composer accounts, but I can't find too many instances outside of them. A quick Github search shows that there's not many occurrences left. |
apaleslimghost
approved these changes
May 28, 2024
|
thanks @hamza-samih! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've changed the permissions in our OIDC nested stack role, in order to remove legacy role assumptions by the old ft-engineer and ft-iam-admin roles. This PR updates to the latest template (v2).
The v2 template has slightly differing permissions, but should affect apps role assumptions, and there should be no effect on deployments.
PR for template changes here: https://github.com/Financial-Times/circleci-nested-stack-template/pull/25