Fix issues with custom plugins #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom plugins can be imported using a relative path. We had previously switched to resolve-pkg to be able to handle plugins without an entrypoint, however this package can't handle resolving relative paths. Additionally, resolve-from's functionality is now available in Node's require API so let's remove both packages (this will also make it easier to migrate to ESM in the future). Now we can roll our own resolution logic that takes what we were using from the resolve-pkg package (resolving a package.json instead of an entrypoint) and adds adds support for relative paths too.
This allows custom plugins (who won't have a schema associated with them) to still use task options.
This was referenced May 17, 2024
ivomurrell
added a commit
that referenced
this pull request
Sep 5, 2024
Fix issues with custom plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes some issues where custom plugins couldn't be loaded nor would their task options be passed to them. Tested with experimentation-api's WIP custom plugin for Node test runner.
Checklist:
feat(circleci): add support for nightly workflows,fix: set Heroku app name for staging apps too