Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ft ui async stylesheets #611

Closed
wants to merge 6 commits into from
Closed

Ft ui async stylesheets #611

wants to merge 6 commits into from

Conversation

adambraimbridge
Copy link
Contributor

@adambraimbridge adambraimbridge commented Oct 4, 2019 •
edited
Loading

See: #581

@adambraimbridge
Copy link
Contributor Author

adambraimbridge commented Oct 15, 2019 •
edited
Loading

@i-like-robots Now that I'm back from holidays, let's go through this PR together and see if it makes sense.

If it does make sense, I'll redo the PR with sensible commit messages.

I suspect the implementation can be improved.

adambraimbridge
adambraimbridge commented Oct 22, 2019
View reviewed changes
packages/dotcom-ui-shell/README.md
@@ -101,6 +101,10 @@ An array of stylesheet URLs to be loaded using `<link rel="stylesheet" />` tags.

An optional string of CSS to embed into the page. Defaults to setting the background colour to FT pink.

#### `asyncStylesheets` (string)

An optional array of stylesheet URLs to be loaded using `<link rel="preload" />` tags.
Copy link
Contributor Author

@adambraimbridge adambraimbridge Oct 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify this reasoning: Why? (not just how)
Also update the 'stylesheets' above

@adambraimbridge
Copy link
Contributor Author

  • Check this in IE11 vm
  • Add a "blocking" example for documentation

@adambraimbridge adambraimbridge self-assigned this Oct 23, 2019
This was referenced Oct 28, 2019
Closed
Closed
@i-like-robots i-like-robots added this to the Release v0.4.0 milestone Oct 31, 2019
@i-like-robots
Copy link
Contributor

Closing in favour of #648

@i-like-robots i-like-robots deleted the ft-ui-async-stylesheets branch February 18, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-like-robots i-like-robots i-like-robots left review comments

Assignees

@adambraimbridge adambraimbridge

Labels
None yet
Projects
None yet
Milestone
Release v0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@adambraimbridge @i-like-robots