Disable sub-brand and transparent o-header styles #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjparkinson
reviewed
Aug 15, 2019
|
|
||
| $o-header-is-silent: false !default; | ||
| // We don't need the sub-brand or transparent header styles so disable them. | ||
| // TODO: move drawer styles into a separate stylesheet which can be lazy loaded? |
There was a problem hiding this comment.
Could/should TODOs be issues on this project?
There was a problem hiding this comment.
I think this one is covered by #546 already!
magsallen
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a list of
o-headerfeatures to output the styles for. By excluding the sub-brand and transparent styles we can reduce the output size by 20%.