Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update n-topic-seach #1126

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Update n-topic-seach #1126

merged 1 commit into from
Jan 27, 2025

Conversation

metart43
Copy link
Member

@metart43 metart43 commented Jan 24, 2025 •
edited
Loading

Description

n-topic-search version 9 removes scss variable $o-spacing-relative-units that overrides unit measurements for consuming applications.

Checklist

Please read the contributing guidelines. In particular, please make sure:

  • I've discussed this feature with the Platforms team
  • This feature is stable, i.e. is not an ongoing experiment, temporary workaround, or hack
  • My branch has been rebased onto the latest commit on main (don't merge main into your branch)

@metart43 metart43 changed the base branch from main to release/11.3 January 24, 2025 11:50
@metart43 metart43 changed the base branch from release/11.3 to v11 January 24, 2025 11:51
@metart43 metart43 force-pushed the am/n-topic-search-fix branch from 7cb9bd5 to db2f849 Compare January 27, 2025 11:09
@metart43 metart43 changed the title test: update n-topic-seach Update n-topic-seach Jan 27, 2025
@metart43 metart43 requested a review from asugar13 January 27, 2025 11:19
@metart43 metart43 changed the base branch from v11 to main January 27, 2025 11:36
@metart43
fix: update n-topic-search
7f5bd7b 
This update removes `$o-spacing-relative-units`
that is globally overriding unit measurements for
consuming apps
@metart43 metart43 force-pushed the am/n-topic-search-fix branch from db2f849 to 7f5bd7b Compare January 27, 2025 11:46
@metart43 metart43 marked this pull request as ready for review January 27, 2025 11:46
@apaleslimghost apaleslimghost merged commit bd984a1 into main Jan 27, 2025
12 checks passed
@apaleslimghost apaleslimghost deleted the am/n-topic-search-fix branch January 27, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apaleslimghost apaleslimghost apaleslimghost approved these changes

@asugar13 asugar13 Awaiting requested review from asugar13

@ft-dependency-auto-merger ft-dependency-auto-merger Awaiting requested review from ft-dependency-auto-merger ft-dependency-auto-merger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metart43 @apaleslimghost