Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOCUS #406 (v1.1 draft): Extend CommitmentDiscountCategory column to categorize on-demand row eligibility for commitments #407

Open
wants to merge 2 commits into
base: working_draft
Choose a base branch
from

Conversation

cnharris10
Copy link
Contributor

@cnharris10 cnharris10 commented Apr 18, 2024

Extend column: CommitmentDiscountCategory provide visibility into commitment-based coverage potential.

A CommitmentDiscountCategory value exists when (assuming a Savings Plan):

  1. ChargeCategory: Purchase --> CommitmentDiscountCategory: Spend
  2. ChargeCategory: Usage, ChargeSubCategory: Used --> CommitmentDiscountCategory: Spend
  3. ChargeCategory: Usage, ChargeSubCategory: Unused --> CommitmentDiscountCategory: Spend

To help practitioners derive Commitment Coverage potential to determine how much more savings is possible, this pr extends CommitmentDiscountCategory with the following scenarios where CommitmentDiscountId is null:

Scenario 4: AWS EC2 VM is eligible for an Reserved Instance or Savings Plan, so Multiple is assigned

  • ChargeCategory: Usage
  • ChargeSubCategory: On-Demand
  • SkuId:
    --> CommitmentDiscountCategory: Multiple

Scenario 5: AWS RDS VM is eligible for a Reserved Instance (only), so Usage is assigned

  • ChargeCategory: Usage
  • ChargeSubCategory: On-Demand
  • SkuId:
    --> CommitmentDiscountCategory: Usage

Scenario 6: AWS Lambda is eligible for a Savings Plan (only), so Spend is assigned

  • ChargeCategory: Usage
  • ChargeSubCategory: On-Demand
  • SkuId:
    --> CommitmentDiscountCategory: Spend

With these additional scenarios, practitioners can calculate their commitment coverage rate (and drill down) as:

(SELECT SUM(ChargePeriodEnd - ChargePeriodStart) FROM <table> WHERE CommitmentDiscountCategory IS NOT NULL AND ChargeSubCategory = 'Used') 
/
(SELECT SUM(ChargePeriodEnd - ChargePeriodEnd) FROM <table> WHERE CommitmentDiscountCategory IS NOT NULL AND ChargeSubCategory IN ('Used', 'On-Demand'))
* 100

@cnharris10 cnharris10 linked an issue Apr 18, 2024 that may be closed by this pull request
3 tasks
@cnharris10 cnharris10 changed the title Issue #406 (1.1 release): Add CommitmentEligibilityName column FOCUS #406 (v1.1 draft): Add CommitmentEligibilityName column Apr 18, 2024
@cnharris10 cnharris10 force-pushed the 406-add-commitment-based-coverage-columns-to-rows-that-are-or-potentially-can-be-covered-by-a-commitment branch 2 times, most recently from 8c10845 to 0c75902 Compare April 18, 2024 17:09
@cnharris10 cnharris10 marked this pull request as ready for review April 18, 2024 17:10
@cnharris10 cnharris10 requested a review from a team as a code owner April 18, 2024 17:10
@cnharris10 cnharris10 force-pushed the 406-add-commitment-based-coverage-columns-to-rows-that-are-or-potentially-can-be-covered-by-a-commitment branch 2 times, most recently from c106f54 to f4a0d2c Compare April 18, 2024 17:13
@jpradocueva jpradocueva added this to the v1.1 milestone Apr 18, 2024
@cnharris10 cnharris10 marked this pull request as draft April 18, 2024 17:57
@cnharris10 cnharris10 force-pushed the 406-add-commitment-based-coverage-columns-to-rows-that-are-or-potentially-can-be-covered-by-a-commitment branch from f4a0d2c to 00d6072 Compare April 18, 2024 19:51
@cnharris10 cnharris10 changed the title FOCUS #406 (v1.1 draft): Add CommitmentEligibilityName column FOCUS #406 (v1.1 draft): Add CommitmentDiscountCategory column Apr 18, 2024
@cnharris10 cnharris10 self-assigned this Apr 18, 2024
@cnharris10 cnharris10 marked this pull request as ready for review April 18, 2024 19:55
@cnharris10 cnharris10 force-pushed the 406-add-commitment-based-coverage-columns-to-rows-that-are-or-potentially-can-be-covered-by-a-commitment branch from 00d6072 to d0811df Compare April 18, 2024 20:19
@cnharris10 cnharris10 changed the title FOCUS #406 (v1.1 draft): Add CommitmentDiscountCategory column FOCUS #406 (v1.1 draft): Exend CommitmentDiscountCategory column to allow for commitment coverage calculations Apr 18, 2024
@cnharris10 cnharris10 changed the title FOCUS #406 (v1.1 draft): Exend CommitmentDiscountCategory column to allow for commitment coverage calculations FOCUS #406 (v1.1 draft): Exend CommitmentDiscountCategory column to categorize on-demand row eligibility for commitments Apr 18, 2024
@cnharris10 cnharris10 force-pushed the 406-add-commitment-based-coverage-columns-to-rows-that-are-or-potentially-can-be-covered-by-a-commitment branch from d0811df to e82e8fb Compare April 18, 2024 20:44
@cnharris10 cnharris10 force-pushed the 406-add-commitment-based-coverage-columns-to-rows-that-are-or-potentially-can-be-covered-by-a-commitment branch from e82e8fb to 98fe5ca Compare April 18, 2024 20:51
@cnharris10 cnharris10 changed the title FOCUS #406 (v1.1 draft): Exend CommitmentDiscountCategory column to categorize on-demand row eligibility for commitments FOCUS #406 (v1.1 draft): Extend CommitmentDiscountCategory column to categorize on-demand row eligibility for commitments Apr 18, 2024
@jpradocueva jpradocueva added the P2 label May 20, 2024
@jpradocueva jpradocueva removed the P2 label Oct 10, 2024
@shawnalpay shawnalpay added needs backlog review Items to review with members and confirm whether to close or carry forward 1.2 consideration To be considered for release 1.2 and removed needs backlog review Items to review with members and confirm whether to close or carry forward labels Oct 30, 2024
@jpradocueva
Copy link
Contributor

Comments from Members' call on Oct 31:

Analysis: Opened to clarify eligibility requirements for on-demand resources with commitments. The resolution hinges on determining overall direction for eligibility.
Agreements: Keep #407 open while confirming eligibility requirements during 1.2 discussions.

@jpradocueva jpradocueva removed this from the v1.1 milestone Nov 5, 2024
@shawnalpay shawnalpay added this to the v1.2 milestone Nov 25, 2024
@shawnalpay shawnalpay added 1.2 Agreed scope for release 1.2 and removed 1.2 consideration To be considered for release 1.2 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.2 Agreed scope for release 1.2
Projects
Status: Parking Lot
Development

Successfully merging this pull request may close these issues.

[Work_Item] Add support for coverage eligibility
3 participants