-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOCUS #406 (v1.1 draft): Extend CommitmentDiscountCategory column to categorize on-demand row eligibility for commitments #407
Open
cnharris10
wants to merge
2
commits into
working_draft
Choose a base branch
from
406-add-commitment-based-coverage-columns-to-rows-that-are-or-potentially-can-be-covered-by-a-commitment
base: working_draft
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
cnharris10
changed the title
Issue #406 (1.1 release): Add CommitmentEligibilityName column
FOCUS #406 (v1.1 draft): Add CommitmentEligibilityName column
Apr 18, 2024
cnharris10
force-pushed
the
406-add-commitment-based-coverage-columns-to-rows-that-are-or-potentially-can-be-covered-by-a-commitment
branch
2 times, most recently
from
April 18, 2024 17:09
8c10845
to
0c75902
Compare
cnharris10
force-pushed
the
406-add-commitment-based-coverage-columns-to-rows-that-are-or-potentially-can-be-covered-by-a-commitment
branch
2 times, most recently
from
April 18, 2024 17:13
c106f54
to
f4a0d2c
Compare
cnharris10
force-pushed
the
406-add-commitment-based-coverage-columns-to-rows-that-are-or-potentially-can-be-covered-by-a-commitment
branch
from
April 18, 2024 19:51
f4a0d2c
to
00d6072
Compare
cnharris10
changed the title
FOCUS #406 (v1.1 draft): Add CommitmentEligibilityName column
FOCUS #406 (v1.1 draft): Add CommitmentDiscountCategory column
Apr 18, 2024
cnharris10
force-pushed
the
406-add-commitment-based-coverage-columns-to-rows-that-are-or-potentially-can-be-covered-by-a-commitment
branch
from
April 18, 2024 20:19
00d6072
to
d0811df
Compare
cnharris10
changed the title
FOCUS #406 (v1.1 draft): Add CommitmentDiscountCategory column
FOCUS #406 (v1.1 draft): Exend CommitmentDiscountCategory column to allow for commitment coverage calculations
Apr 18, 2024
cnharris10
changed the title
FOCUS #406 (v1.1 draft): Exend CommitmentDiscountCategory column to allow for commitment coverage calculations
FOCUS #406 (v1.1 draft): Exend CommitmentDiscountCategory column to categorize on-demand row eligibility for commitments
Apr 18, 2024
cnharris10
force-pushed
the
406-add-commitment-based-coverage-columns-to-rows-that-are-or-potentially-can-be-covered-by-a-commitment
branch
from
April 18, 2024 20:44
d0811df
to
e82e8fb
Compare
…tails to be derived
cnharris10
force-pushed
the
406-add-commitment-based-coverage-columns-to-rows-that-are-or-potentially-can-be-covered-by-a-commitment
branch
from
April 18, 2024 20:51
e82e8fb
to
98fe5ca
Compare
cnharris10
changed the title
FOCUS #406 (v1.1 draft): Exend CommitmentDiscountCategory column to categorize on-demand row eligibility for commitments
FOCUS #406 (v1.1 draft): Extend CommitmentDiscountCategory column to categorize on-demand row eligibility for commitments
Apr 18, 2024
shawnalpay
added
needs backlog review
Items to review with members and confirm whether to close or carry forward
1.2 consideration
To be considered for release 1.2
and removed
needs backlog review
Items to review with members and confirm whether to close or carry forward
labels
Oct 30, 2024
Comments from Members' call on Oct 31:Analysis: Opened to clarify eligibility requirements for on-demand resources with commitments. The resolution hinges on determining overall direction for eligibility. |
shawnalpay
added
1.2
Agreed scope for release 1.2
and removed
1.2 consideration
To be considered for release 1.2
labels
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend column:
CommitmentDiscountCategory
provide visibility into commitment-based coverage potential.A CommitmentDiscountCategory value exists when (assuming a Savings Plan):
To help practitioners derive Commitment Coverage potential to determine how much more savings is possible, this pr extends
CommitmentDiscountCategory
with the following scenarios whereCommitmentDiscountId
is null:Scenario 4: AWS EC2 VM is eligible for an Reserved Instance or Savings Plan, so
Multiple
is assigned--> CommitmentDiscountCategory: Multiple
Scenario 5: AWS RDS VM is eligible for a Reserved Instance (only), so
Usage
is assigned--> CommitmentDiscountCategory: Usage
Scenario 6: AWS Lambda is eligible for a Savings Plan (only), so
Spend
is assigned--> CommitmentDiscountCategory: Spend
With these additional scenarios, practitioners can calculate their commitment coverage rate (and drill down) as: