Added links and aligned with other Type columns

FinOps-Open-Cost-and-Usage-Spec · Nov 17, 2023 · af2d6f7 · af2d6f7
1 parent 248eaa8
commit af2d6f7
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 11 deletions.
diff --git a/specification/columns/billingaccounttype.md b/specification/columns/billingaccounttype.md
@@ -1,8 +1,8 @@
 # Billing Account Type
 
-Billing Account Type is the label the provider uses to describe the kind of the billing account. Billing Account Type is a readable display name and not a code. Billing Account Type is commonly used for scenarios like mapping FOCUS constructs to provider constructs and summarizing costs across providers.
+Billing Account Type is the label the provider uses to describe the kind of [*billing account*](#glossary:billing-account). Billing Account Type is a readable display name and not a code. Billing Account Type is commonly used for scenarios like mapping FOCUS constructs to provider constructs and summarizing costs across providers.
 
-The BillingAccountType column MUST be present and MUST NOT be null or empty. This column MUST be of type String and MUST NOT be null when BillingAccountId is not null. When BillingAccountId is null, BillingAccountType MUST also be null. Providers MUST use a consistent value-format and a set of values for BillingAccountType values within their cost and usage datasets.
+The BillingAccountType column MUST be present in the billing data. This column MUST be of type String, MUST be null when [BillingAccountId](#billingaccountid) is null, and MUST NOT be null when BillingAccountId is not null. BillingAccountType MUST be a consistent, readable display value within the billing data.
 
 ## Column ID
 
@@ -20,9 +20,10 @@ Label the provider uses to describe the kind of billing account.
 
 | Constraint      | Value            |
 | :-------------- | :--------------- |
+| Column type     | Dimension        |
 | Column required | True             |
-| Data type       | String           |
 | Allows nulls    | False            |
+| Data type       | String           |
 | Value format    | \<not specified> |
 
 ## Introduced (version)

diff --git a/specification/columns/commitmentdiscounttype.md b/specification/columns/commitmentdiscounttype.md
@@ -2,26 +2,26 @@
 
 Commitment Discount Type is a provider-assigned name to identify the type of [*commitment-based discount*](#glossary:commitment-based-discount) applied to the [*row*](#glossary:row).
 
-The CommitmentDiscountType column MUST be present in the billing data. This column MUST be of type String, MUST be null when [CommitmentDiscountId](#commitmentdiscountid) is null, and MUST NOT be null when CommitmentDiscountId is not null. Providers MUST use a consistent value-format and a set of values for CommitmentDiscountType values within their billing datasets.
+The CommitmentDiscountType column MUST be present in the billing data. This column MUST be of type String, MUST be null when [CommitmentDiscountId](#commitmentdiscountid) is null, and MUST NOT be null when CommitmentDiscountId is not null. CommitmentDiscountType MUST be a consistent,readable display value within the billing data.
 
 ## Column ID
 
 CommitmentDiscountType
 
-## Display name
+## Display Name
 
 Commitment Discount Type
 
 ## Description
 
 A provider-assigned identifier for the type of *commitment-based discount* applied to the *row*.
 
-## Content constraints
+## Content Constraints
 
 | Constraint      | Value            |
 |:----------------|:-----------------|
 | Column type     | Dimension        |
-| Column required | False            |
+| Column required | True             |
 | Allows nulls    | True             |
 | Data type       | String           |
 | Value format    | \<not specified> |

diff --git a/specification/columns/resourcetype.md b/specification/columns/resourcetype.md
@@ -2,7 +2,7 @@
 
 Resource Type describes the kind of [*resource*](#glossary:resource) the charge applies to.  A Resource Type is commonly used for scenarios like identifying cost changes in groups of similar *resources* and may include values like Virtual Machine, Data Warehouse, and Load Balancer.
 
-The ResourceType column MUST be present within billing data.  This column MUST be of type String and MUST NOT be null when a corresponding [ResourceId](#resourceid) is not null.  When a corresponding ResourceId value is null, the ResourceType column value MUST also be null.  Providers MUST use a consistent value-format and a set of values for ResourceType values within their billing datasets.
+The ResourceType column MUST be present within billing data. This column MUST be of type String, MUST be null when [ResourceId](#resourceid) is null, and MUST NOT be null when ResourceId is not null. ResourceType SHOULD be a readable display value and MUST use a consistent value-format and a set of values for ResourceType values within the billing data.
 
 ## Column ID
 

diff --git a/specification/columns/subaccounttype.md b/specification/columns/subaccounttype.md
@@ -1,8 +1,8 @@
 # Sub Account Type
 
-Sub Account Type is the label the provider uses to describe the kind of the sub account. Sub Account Type is a readable display name and not a code. Sub Account Type is commonly used for scenarios like mapping FOCUS constructs to provider constructs and summarizing costs across providers.
+Sub Account Type is the label the provider uses to describe the kind of [*sub account*](#glossary:sub-account). Sub Account Type is a readable display name and not a code. Sub Account Type is commonly used for scenarios like mapping FOCUS constructs to provider constructs and summarizing costs across providers.
 
-The SubAccountType column MUST be present and MUST NOT be null or empty. This column MUST be of type String and MUST NOT be null when SubAccountId is not null. When SubAccountId is null, SubAccountType MUST also be null. Providers MUST use a consistent value-format and a set of values for SubAccountType values within their cost and usage datasets.
+The SubAccountType column MUST be present in the billing data. This column MUST be of type String, MUST be null when [SubAccountId](#subaccountid) is null, and MUST NOT be null when SubAccountId is not null. SubAccountType MUST be a consistent, readable display value within the billing data.
 
 ## Column ID
 
@@ -20,9 +20,10 @@ Label the provider uses to describe the kind of sub account.
 
 | Constraint      | Value            |
 | :-------------- | :--------------- |
+| Column type     | Dimension        |
 | Column required | True             |
+| Allows nulls    | True             |
 | Data type       | String           |
-| Allows nulls    | False            |
 | Value format    | \<not specified> |
 
 ## Introduced (version)