Issue154 upgrade smart contracts to provwasm 2.0.0 #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EasyEtHP4 / @kherzinger-figure FYI - relevant while you are still on the smart contract |
leeduan
commented
Jul 11, 2023
| .mock_querier | ||
| .update_balance("customer", vec![dcc]); | ||
|
|
||
| // TODO - fix test since mock response returns same result no matter the input |
There was a problem hiding this comment.
waiting on resolution from provwasm team about mocking not considering the inputs of the query
leeduan
commented
Jul 11, 2023
| @@ -1739,9 +2010,30 @@ mod tests { | |||
| ) | |||
| .unwrap(); | |||
|
|
|||
| // TODO - fix mock response so it is only returnable for checking bank2 and not bank1 | |||
There was a problem hiding this comment.
waiting on resolution from provwasm team about mocking not considering the inputs of the query
jtalis
previously approved these changes
Jul 13, 2023
smart-contract-sale/Cargo.toml
Outdated
| cw2 = "1.0.1" | ||
| provwasm-std = { version = "1.1.2" } | ||
| provwasm-std = { version = "2.0.0-rc1" } |
There was a problem hiding this comment.
looks like 2.0.0 has been released - https://github.com/provenance-io/provwasm/releases/tag/v2.0.0
There was a problem hiding this comment.
for some reason they never published it on crate...
jtalis
approved these changes
Jul 17, 2023
leeduan
requested review from
ranadewall,
scirner22 and
mwoods-figure
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration guide: https://github.com/provenance-io/provwasm/blob/main/MIGRATION.md
There are a couple broken tests right now that are waiting on this discussion: https://discord.com/channels/897185242182484029/1115703566737342474/1128040123989242008