Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric names might be tuples, they have to be escaped in match specs. #146

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

kape1395
Copy link
Contributor

@kape1395 kape1395 commented Jul 4, 2024

If an entry name has tuples and a custom entry type is used, the tuples are used as part of the match-spec. They must be escaped.

@uwiger
Copy link
Member

uwiger commented Jul 4, 2024

Good catch (although the comment to exometer_admin:set_default() says the name should be a list of atoms).

I suggest adding a test case. Here is an example you may use:
https://github.com/Feuerlabs/exometer_core/tree/uw-fix_name_tuples-add-test

@kape1395
Copy link
Contributor Author

kape1395 commented Jul 4, 2024

Thanks for the test case. I have merged it into the PR.

@uwiger uwiger merged commit f65ec52 into Feuerlabs:master Jul 4, 2024
6 checks passed
@uwiger
Copy link
Member

uwiger commented Jul 4, 2024

Thanks - merged.

@uwiger
Copy link
Member

uwiger commented Jul 4, 2024

Tagged as 1.7.0 and published to hex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants