Don't duplicate the metric options.

Signed-off-by: Karolis Petrauskas <[email protected]>
Feuerlabs · Aug 22, 2024 · a4ea0e2 · a4ea0e2
1 parent f65ec52
commit a4ea0e2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/exometer_admin.erl b/src/exometer_admin.erl
@@ -332,7 +332,7 @@ handle_call({ensure, Name, Type, Opts}, _From, S) ->
         [] ->
             #exometer_entry{options = OptsTemplate} = E0 =
                 lookup_definition(Name, Type, Opts),
-            E1 = process_opts(E0, OptsTemplate ++ Opts),
+            E1 = process_opts(E0, OptsTemplate),
             Res = exometer:create_entry(E1),
             report_new_entry(E1),
             {reply, Res, S}

diff --git a/test/exometer_SUITE.erl b/test/exometer_SUITE.erl
@@ -43,7 +43,8 @@
     test_app_predef/1,
     test_function_match/1,
     test_status/1,
-    test_slide_ignore_outdated/1
+    test_slide_ignore_outdated/1,
+    test_info_options/1
    ]).
 
 %% utility exports
@@ -113,7 +114,8 @@ groups() ->
       ]},
      {test_info, [shuffle],
       [
-       test_status
+       test_status,
+       test_info_options
       ]}
     ].
 
@@ -502,6 +504,13 @@ test_slide_ignore_outdated(_Config) ->
 
    ok.
 
+
+% Check if options are not duplicated.
+test_info_options(_Config) ->
+    ok = exometer:new([?FUNCTION_NAME], gauge, [{custom_opt, works}]),
+    [{custom_opt,works}] = exometer:info([?FUNCTION_NAME], options).
+
+
 %%%===================================================================
 %%% Internal functions
 %%%===================================================================