-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code splitting #156
Open
NeoLegends
wants to merge
14
commits into
develop
Choose a base branch
from
feature/lazy-loading
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Code splitting #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also apply some fixes.
NeoLegends
force-pushed
the
feature/lazy-loading
branch
from
May 26, 2018 11:37
34a4486
to
84c2944
Compare
mraerino
force-pushed
the
feature/lazy-loading
branch
from
May 31, 2018 11:50
55bc10c
to
b4fd999
Compare
This is currently done less optimally than possible but works alright.
The new build also supports browsers with a shitty JS Engine, so there shouldn't be any problems anymore.
NeoLegends
force-pushed
the
feature/lazy-loading
branch
from
June 1, 2018 19:28
bfd0fbc
to
e0f1557
Compare
mraerino
force-pushed
the
develop
branch
2 times, most recently
from
April 23, 2019 12:59
9f5a930
to
9e40e3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We configure Rollup to build two versions of Festify. One for browsers with native ES module support, the other one using SystemJS.
Primary goal is to remove the Polymer and firebase/database dependencies from the app-shell bundle (respectively the initial bundle), which will greatly reduce the code we have to load upfront. See #147.