-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add versioning tool #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- ferretdb_packaging/.gitignore: Language not supported
- ferretdb_packaging/go.mod: Language not supported
Comments suppressed due to low confidence (1)
ferretdb_packaging/defineversion/main.go:37
- [nitpick] The error message "-control-file flag is empty." is unclear. Consider changing it to "The -control-file flag must be provided and cannot be empty."
action.Fatalf("%s", "-control-file flag is empty.")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should do a better job separating extension version, Debian package version, and git tag name in both terminology and code. For example, it looks like parseVersion
tries to parse everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, let's remove all checks for default_version
from that PR. We will introduce them later, once we have a better understanding of it all.
For release tags, it's not necessary to use For PR, branch builds etc, upstream version need to start with some digit. I think using
https://www.debian.org/doc/debian-policy/ch-controlfields.html#version |
Closes FerretDB/FerretDB#4724.