Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioning tool #3

Merged
merged 23 commits into from
Feb 19, 2025
Merged

Add versioning tool #3

merged 23 commits into from
Feb 19, 2025

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow self-assigned this Feb 18, 2025
@chilagrow chilagrow marked this pull request as ready for review February 18, 2025 08:22
@chilagrow chilagrow requested review from a team, AlekSi and noisersup February 18, 2025 08:23
@AlekSi AlekSi requested a review from Copilot February 18, 2025 11:10
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

Files not reviewed (2)
  • ferretdb_packaging/.gitignore: Language not supported
  • ferretdb_packaging/go.mod: Language not supported
Comments suppressed due to low confidence (1)

ferretdb_packaging/defineversion/main.go:37

  • [nitpick] The error message "-control-file flag is empty." is unclear. Consider changing it to "The -control-file flag must be provided and cannot be empty."
action.Fatalf("%s", "-control-file flag is empty.")

ferretdb_packaging/defineversion/main.go Outdated Show resolved Hide resolved
ferretdb_packaging/go.mod Outdated Show resolved Hide resolved
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do a better job separating extension version, Debian package version, and git tag name in both terminology and code. For example, it looks like parseVersion tries to parse everything.

.github/workflows/ferretdb_go_tests.yml Outdated Show resolved Hide resolved
.github/workflows/ferretdb_go_tests.yml Show resolved Hide resolved
ferretdb_packaging/defineversion/main_test.go Outdated Show resolved Hide resolved
ferretdb_packaging/defineversion/main_test.go Outdated Show resolved Hide resolved
ferretdb_packaging/defineversion/main.go Outdated Show resolved Hide resolved
ferretdb_packaging/defineversion/main.go Outdated Show resolved Hide resolved
ferretdb_packaging/defineversion/main_test.go Outdated Show resolved Hide resolved
ferretdb_packaging/defineversion/main.go Outdated Show resolved Hide resolved
ferretdb_packaging/defineversion/main.go Outdated Show resolved Hide resolved
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, let's remove all checks for default_version from that PR. We will introduce them later, once we have a better understanding of it all.

@chilagrow
Copy link
Member Author

Actually, let's remove all checks for default_version from that PR. We will introduce them later, once we have a better understanding of it all.

For release tags, it's not necessary to use default_version.

For PR, branch builds etc, upstream version need to start with some digit. I think using default_version for that makes sense for the time being.

The upstream_version must contain only alphanumerics 6 and the characters . + - ~ (full stop, plus, hyphen, tilde) and should start with a digit.

https://www.debian.org/doc/debian-policy/ch-controlfields.html#version

@chilagrow chilagrow requested a review from AlekSi February 19, 2025 04:02
ferretdb_packaging/defineversion/main.go Outdated Show resolved Hide resolved
ferretdb_packaging/defineversion/main.go Outdated Show resolved Hide resolved
ferretdb_packaging/defineversion/main.go Outdated Show resolved Hide resolved
ferretdb_packaging/defineversion/main.go Outdated Show resolved Hide resolved
@chilagrow chilagrow requested a review from AlekSi February 19, 2025 08:59
@AlekSi AlekSi merged commit fc8f917 into FerretDB:ferretdb Feb 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Build DocumentDB .deb packages on CI
3 participants